Add commissioning complete callback and timer. #6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a timer to the arm failsafe call, and generates a device event (kCommissioningComplete) when the commissioning complete call happens or when the failsafe timer is triggered.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
mspang
Damian-Nordic
approved these changes
May 11, 2021
| @@ -28,17 +28,32 @@ namespace chip { | |||
| namespace DeviceLayer { | |||
| namespace Internal { | |||
|
|
|||
| void CommissioningTimerFunction(System::Layer * layer, void * aAppState, System::Error aError) | |||
| { | |||
| DeviceControlServer * server = reinterpret_cast<DeviceControlServer *>(aAppState); | |||
There was a problem hiding this comment.
nit: static_cast would be enough
jmartinez-silabs
approved these changes
May 11, 2021
jelderton
approved these changes
May 11, 2021
andy31415
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a timer to the arm failsafe call, and generates a device event
(kCommissioningComplete) when the commissioning complete call happens
or when the failsafe timer is triggered.
Problem
Arm failsafe and commissioning complete commands don't currently do anything.
Summary of Changes
Adds a timer to the arm failsafe call, and generates a device event
(kCommissioningComplete) when the commissioning complete call happens
or when the failsafe timer is triggered
Fixes #6672