-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dns-sd] fix SRP service name length #6626
Conversation
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
On this PR I see the 'run unit tests' stuck in the run state (without output unfortunately) for 50 minutes. Unsure if PR-specific or a flake. Given that every one of the runners does this, it may be something in the change itself. |
I cancelled the workflows with the intent of restarting them, however I do not seem to get a 'restart all' button yet. |
Size increase report for "esp32-example-build" from 8185019
Full report output
|
Size increase report for "nrfconnect-example-build" from 8185019
Full report output
|
I kicked the Tests again, for some reason they're getting stuck... |
I am totally puzzled here - I have never seen these tests hang on any other PR, however I am unclear on why this PR would cause system tests to misbehave either (and across all compilers to boot). I did copy the PR and tried locally, it passes (except I found a Mdns hang which I fixed in #6721). Kangping reported his workstation hangs on TestSystemObject but I could not see that. |
@woody-apple @andy31415 Thanks for helping resolve the test hang issue. I am sorry that it is too later for me to fix this issue last night, but it seems the hang issue is caused by the failure of the I submitted #6771 to fix the issue. |
Problem
The SRP service name buffers are too small.
Summary of Changes
Fix SRP service & host name buffer issue.