Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for System Layer event handler crash #6568

Merged
merged 1 commit into from
May 7, 2021

Conversation

sweetymhaiske
Copy link
Contributor

Problem

System Layer Handler crash when level change commands are sent in quick succession.

Summary of Changes

For 0 delay StartTimer( ) invokes the handler immediately, which collides with the handler invoked by emberEventControlSetActive.

Fixes #5678

@github-actions
Copy link

github-actions bot commented May 7, 2021

Size increase report for "esp32-example-build" from c5fff85

File Section File VM
chip-all-clusters-app.elf .flash.text -40 -40
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.shstrtab,0,-1
.xt.prop._ZTVN4chip24LifetimePersistedCounterE,0,-2
.symtab,0,-16
.debug_line,0,-22
.flash.text,-40,-40
.strtab,0,-51
.debug_loc,0,-85
.debug_abbrev,0,-93
.debug_info,0,-102

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@github-actions
Copy link

github-actions bot commented May 7, 2021

Size increase report for "nrfconnect-example-build" from c5fff85

File Section File VM
chip-lock.elf device_handles -12 -12
chip-lock.elf text -132 -132
chip-lighting.elf device_handles 4 4
chip-lighting.elf text -132 -132
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.shstrtab,0,-3
device_handles,-12,-12
.debug_line,0,-24
.debug_ranges,0,-24
.debug_abbrev,0,-39
.debug_info,0,-77
.debug_loc,0,-100
.symtab,0,-112
text,-132,-132
.strtab,0,-161

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
device_handles,4,4
.shstrtab,0,-3
.debug_line,0,-21
.debug_ranges,0,-24
.debug_abbrev,0,-68
.debug_info,0,-79
.debug_loc,0,-104
.symtab,0,-112
text,-132,-132
.strtab,0,-161


@sweetymhaiske
Copy link
Contributor Author

sweetymhaiske commented May 7, 2021

@sagar-apple sagar-apple requested a review from vivien-apple May 7, 2021 07:30
@andy31415 andy31415 merged commit 51154fd into project-chip:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Crash] System Layer crash: Wrong handler! in chip::System::Layer::HandleEvent
6 participants