Fixing compile issue on Mac #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem The error of implicit conversion loses integer precision appears in compile time Summary of Changes - Updated the CHIPPersistentStorageDelegateBridge.mm file Test - Used the gn_build.sh to verify the building is successful
andy31415
approved these changes
May 6, 2021
|
Pushed as admin - even with hotfix label, apparently restyle check takes > 15 minutes. Our CI si extreamly slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The error of implicit conversion loses integer precision appears in compile time
Summary of Changes
Test
./gn_build.shto verify the building is successful