Remove endpoint 5 on the tv-app as it creates some random ZAP behavior #6447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
|
Awesome. The Endpint 5 is not needed at all. It was there only for testing purposes. |
woody-apple
approved these changes
May 4, 2021
|
Marking this as hotfix, given it's breaking builds pretty reliably... |
|
all auto-generated code so looks safe to approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our ZAP CI is randomly failing because the
tv-app.zapconfiguration is breaking some assertions made by ZAP afaict.Looking into the configuration of the
tv-appI guess the endpoint 5 can be removed. This endpoint is configured to act similarly to theall-clusters-appbut it conflicts with the device type used for the rest of the app.Summary of Changes
gen/folder