Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Add IM/Ember Read/Writer Interface and attribute read for IM for TE3 #6326

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Apr 28, 2021

A duplicate of #6214 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

yunhanw-google and others added 2 commits April 27, 2021 20:46
Summary of Changes:
-- Add initial IM read attribute implementation and ember read/write
interface so that read client can send IM read request with attribute
path,  interaction model engine receive this request and ask
reporting engine generate the corresponding interested attributes and
send it back via read hander.

-- Add unit and cirque integration test
@restyled-io restyled-io bot added the restyled label Apr 28, 2021
@todo
Copy link

todo bot commented Apr 28, 2021

Add DataVersion support

// TODO: Add DataVersion support
exit:
aClusterInfo.ClearDirty();
if (err != CHIP_NO_ERROR)
{
ChipLogError(DataManagement, "Error retrieving data from clusterId: %08x, err = %d",
aClusterInfo.mAttributePathParams.mClusterId, err);
}


This comment was generated by todo based on a TODO comment in 2ca97d2 in #6326. cc @project-chip.

@boring-cyborg boring-cyborg bot added the app label Apr 28, 2021
@todo
Copy link

todo bot commented Apr 28, 2021

Need to handle multiple chunk of message

// TODO: Need to handle multiple chunk of message
while (clusterInfo != nullptr)
{
if (clusterInfo->IsDirty())
{
AttributeDataElement::Builder attributeDataElementBuilder = attributeDataList.CreateAttributeDataElementBuilder();
ChipLogDetail(DataManagement, "<RE:Run> Cluster %u, Field %u is dirty", clusterInfo->mAttributePathParams.mClusterId,
clusterInfo->mAttributePathParams.mFieldId);
// Retrieve data for this cluster instance and clear its dirty flag.
err = RetrieveClusterData(attributeDataElementBuilder, *clusterInfo);
VerifyOrExit(err == CHIP_NO_ERROR,


This comment was generated by todo based on a TODO comment in 2ca97d2 in #6326. cc @project-chip.

@restyled-io restyled-io bot closed this Apr 28, 2021
@restyled-io restyled-io bot deleted the restyled/pull-6214 branch April 28, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants