Restyle Convert persistent storage to sync calls and binary data to align with KVS style storage

[restyled-io]

A duplicate of #6286 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

• clang-format

To incorporate these changes, you can either:

1. Merge this Pull Request instead of the original, or

2. Ask your contributor to locally incorporate these commits and push them to
   the original Pull Request

   Expand for example instructions

   ```console
   git remote add upstream https://github.com/project-chip/connectedhomeip.git
   git fetch upstream pull/<this PR number>/head
   git merge --ff-only FETCH_HEAD
   git push
   ```
   

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

[todo]

no need to base-64 the serialized values AGAIN

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 378 to 383 in 6121842

	// TODO: no need to base-64 the serialized values AGAIN
	PERSISTENT_KEY_OP(device->GetDeviceId(), kPairedDeviceKeyPrefix, key,
	mStorageDelegate->SyncSetKeyValue(key, serialized.inner, sizeof(serialized.inner)));
	}
	}

---

This comment was generated by todo based on a TODO comment in 6121842 in #6294. cc @project-chip.

[todo]

no need to base64 again the value

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 952 to 962 in 6121842

	// TODO: no need to base64 again the value
	PERSISTENT_KEY_OP(static_cast<uint64_t>(0), kPairedDeviceListKeyPrefix, key,
	mStorageDelegate->SyncSetKeyValue(key, value, static_cast<uint16_t>(strlen(value))));
	mPairedDevicesUpdated = false;
	}
	chip::Platform::MemoryFree(serialized);
	}
	mStorageDelegate->SyncSetKeyValue(kNextAvailableKeyID, &mNextKeyId, sizeof(mNextKeyId));
	}
	}

---

This comment was generated by todo based on a TODO comment in 6121842 in #6294. cc @project-chip.

[todo]

ideally the error from the dispatch should be returned

connectedhomeip/src/darwin/Framework/CHIP/CHIPPersistentStorageDelegateBridge.mm

Lines 135 to 145 in 6121842

	// TODO: ideally the error from the dispatch should be returned
	// however we expect to replace the storage delegate with KVS so for now
	// we return no error (return used to be void due to async dispatch anyway)
	return CHIP_NO_ERROR;
	}
	CHIP_ERROR CHIPPersistentStorageDelegateBridge::SyncDeleteKeyValue(const char * key)
	{
	NSString * keyString = [NSString stringWithUTF8String:key];
	dispatch_async(mWorkQueue, ^{

---

This comment was generated by todo based on a TODO comment in 6121842 in #6294. cc @project-chip.

[todo]

ideally the error from the dispatch should be returned

connectedhomeip/src/darwin/Framework/CHIP/CHIPPersistentStorageDelegateBridge.mm

Lines 158 to 163 in 6121842

	// TODO: ideally the error from the dispatch should be returned
	// however we expect to replace the storage delegate with KVS so for now
	// we return no error (return used to be void due to async dispatch anyway)
	return CHIP_NO_ERROR;
	}

---

This comment was generated by todo based on a TODO comment in 6121842 in #6294. cc @project-chip.