Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck (should also resurrect Tidy) #60

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Fix shellcheck (should also resurrect Tidy) #60

merged 1 commit into from
Mar 17, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

GitHub workflow names need to have an initial capital letter, apparently,
or need to differ from the list of jobs inside. Without the initial capital letter,
the workflow is ignored or actions parsing halts, not sure which.

Changes

  • capitalize shellcheck's "name:"
  • remove unnecessary repo token argument (copy pasta)

Fix shellcheck (should also resurrect Tidy)
ddd8411 
 ### Problem
 GitHub workflow names need to have an initial capital letter, apparently,
 or need to differ from the list of jobs inside. Without the initial capital letter,
 the workflow is ignored or actions parsing halts, not sure which.

 ### Changes
 * capitalize shellcheck's "name:"
 * remove unnecessary repo token argument (copy pasta)
@woody-apple
Copy link
Contributor

@hawk248 @BroderickCarlin Thoughts?

@rwalker-apple
Copy link
Contributor Author

note that this may conflict with #58, I'll evaluate later today

BroderickCarlin
BroderickCarlin approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@BroderickCarlin BroderickCarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming there is no conflict

@woody-apple
Copy link
Contributor

note that this may conflict with #58, I'll evaluate later today

@rwalker-apple Let me know when you are good to go, and I'll merge.

@rwalker-apple
Copy link
Contributor Author

should work fine, assuming #58 hasn't landed

@woody-apple woody-apple merged commit 5fa438d into project-chip:master Mar 17, 2020
@rwalker-apple rwalker-apple deleted the Fix-shellcheck branch March 17, 2020 18:41
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Sep 12, 2022
@silabsbot @selissia
Pull request project-chip#60: MATTER-708: change board to BRD4187C
800cac6 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox Oct 6, 2022
@silabsbot @mkardous-silabs
Pull request #60: MATTER-708: change board to BRD4187C
e74e5af 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@silabsbot @jmartinez-silabs
Pull request project-chip#60: MATTER-708: change board to BRD4187C
ee751c1 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Oct 24, 2022
@silabsbot @jmartinez-silabs
Pull request #60: MATTER-708: change board to BRD4187C
f0f17e4 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@silabsbot @jmartinez-silabs
Pull request #60: MATTER-708: change board to BRD4187C
489ac42 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@silabsbot @jmartinez-silabs
Pull request project-chip#60: MATTER-708: change board to BRD4187C
e6f6fd3 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
@M201370367 M201370367 mentioned this pull request Oct 25, 2023
Open
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@silabsbot @jmartinez-silabs
Pull request project-chip#60: MATTER-708: change board to BRD4187C
bcb93eb 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@silabsbot @jmartinez-silabs
Pull request project-chip#60: MATTER-708: change board to BRD4187C
b2d06d8 
Merge in WMN_TOOLS/matter from bugfix/MATTER-708 to silabs

Squashed commit of the following:

commit 49dc05608bf8814d7d666a6122f9f38b2a7a901f
Author: Yulina Shu <[email protected]>
Date:   Wed Aug 31 20:40:13 2022 +0000

    MATTER-708: change board to BRD4187C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @woody-apple @gerickson @BroderickCarlin