WIP: Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #500

gerickson · 2020-04-24T17:26:49Z

Problem

TestInet{EndPoint,LayerDNS} needs IPv6 support and Docker on macOS does not support (and has not supported) IPv6.

Summary of Changes

However, now that we have stood up CI against Travis CI and/or GitHub actions with Docker on Linux instances, this may be mitigated and only an issue for local developers on macOS.

Trying moving TestInet{EndPoint,LayerDNS} from noinst_PROGRAMS back to check_PROGRAMS.

Fixes #323 and #329

gerickson · 2020-04-24T17:53:51Z

Negative. TestInet{EndPoint,LayerDNS} still fail with Docker:

make -C ../../../src/include/ CHIPVersion.h
make -C ../../ .local-version
  CHECK         .local-version
  CHECK         CHIPVersion.h
FAIL: TestInetEndPoint
PASS: TestInetErrorStr
FAIL: TestInetLayerDNS
PASS: TestInetTimer
============================================================================
Testsuite summary for Chip g43992b7
============================================================================
# TOTAL: 6
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See src/inet/tests/test-suite.log
Please report to [email protected]
============================================================================
Makefile:1106: recipe for target 'test-suite.log' failed
make[6]: *** [test-suite.log] Error 1
Makefile:1212: recipe for target 'check-TESTS' failed
make[5]: *** [check-TESTS] Error 2
Makefile:1320: recipe for target 'check-am' failed
make[4]: *** [check-am] Error 2
Makefile:1155: recipe for target 'check-recursive' failed
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
Makefile:573: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
Makefile:702: recipe for target 'check-recursive' failed
Makefile:994: recipe for target 'check' failed
make: *** [check] Error 2
make: Leaving directory '/home/travis/build/project-chip/connectedhomeip/build/default'
The command "./integrations/ci-tools/build.sh" exited with 2.

Though for Linux hosts on Travis CI, it looks like it should work if so configured with this: https://docs.docker.com/config/daemon/ipv6/.

gerickson · 2020-04-24T18:08:15Z

Negative. TestInet{EndPoint,LayerDNS} still fail with Docker:

make -C ../../../src/include/ CHIPVersion.h
make -C ../../ .local-version
  CHECK         .local-version
  CHECK         CHIPVersion.h
FAIL: TestInetEndPoint
PASS: TestInetErrorStr
FAIL: TestInetLayerDNS
PASS: TestInetTimer
============================================================================
Testsuite summary for Chip g43992b7
============================================================================
# TOTAL: 6
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See src/inet/tests/test-suite.log
Please report to [email protected]
============================================================================
Makefile:1106: recipe for target 'test-suite.log' failed
make[6]: *** [test-suite.log] Error 1
Makefile:1212: recipe for target 'check-TESTS' failed
make[5]: *** [check-TESTS] Error 2
Makefile:1320: recipe for target 'check-am' failed
make[4]: *** [check-am] Error 2
Makefile:1155: recipe for target 'check-recursive' failed
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
Makefile:573: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
Makefile:702: recipe for target 'check-recursive' failed
Makefile:994: recipe for target 'check' failed
make: *** [check] Error 2
make: Leaving directory '/home/travis/build/project-chip/connectedhomeip/build/default'
The command "./integrations/ci-tools/build.sh" exited with 2.

Though for Linux hosts on Travis CI, it looks like it should work if so configured with this: https://docs.docker.com/config/daemon/ipv6/.

Trying 9dcd412 to see if that, at least, addresses the issue in the base Travis CI Linux container. There may still be more Docker configuration required.

gerickson · 2020-04-24T18:50:04Z

Negative. TestInet{EndPoint,LayerDNS} still fail with Docker:

make -C ../../../src/include/ CHIPVersion.h
make -C ../../ .local-version
  CHECK         .local-version
  CHECK         CHIPVersion.h
FAIL: TestInetEndPoint
PASS: TestInetErrorStr
FAIL: TestInetLayerDNS
PASS: TestInetTimer
============================================================================
Testsuite summary for Chip g43992b7
============================================================================
# TOTAL: 6
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See src/inet/tests/test-suite.log
Please report to [email protected]
============================================================================
Makefile:1106: recipe for target 'test-suite.log' failed
make[6]: *** [test-suite.log] Error 1
Makefile:1212: recipe for target 'check-TESTS' failed
make[5]: *** [check-TESTS] Error 2
Makefile:1320: recipe for target 'check-am' failed
make[4]: *** [check-am] Error 2
Makefile:1155: recipe for target 'check-recursive' failed
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
Makefile:573: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
Makefile:702: recipe for target 'check-recursive' failed
Makefile:994: recipe for target 'check' failed
make: *** [check] Error 2
make: Leaving directory '/home/travis/build/project-chip/connectedhomeip/build/default'
The command "./integrations/ci-tools/build.sh" exited with 2.

Though for Linux hosts on Travis CI, it looks like it should work if so configured with this: https://docs.docker.com/config/daemon/ipv6/.

Trying 9dcd412 to see if that, at least, addresses the issue in the base Travis CI Linux container. There may still be more Docker configuration required.

No go with that change. Will try something alone these lines.

BroderickCarlin · 2020-04-25T04:19:21Z

integrations/travis/before_install.sh

+
+  linux)
+    # By default, Travis CI does not have IPv6 enabled on
+    # Linux. Ensure that IPv6 is enabled since Weave, and its unit


nit: Change Weave to CHIP

rwalker-apple · 2020-04-25T07:21:39Z

If you please: ensure unrelated commits you've incorporated have already landed prior to this one landing? This looks blunderbuss-y. I recognize some of the work, but not all.

gerickson · 2020-04-27T16:40:35Z

If you please: ensure unrelated commits you've incorporated have already landed prior to this one landing? This looks blunderbuss-y. I recognize some of the work, but not all.

Yes, this is a WIP PR and should have been a draft as an experiment to try to get IPv6 working in Docker on Travis. I'll mark it as such.

gerickson · 2020-05-11T16:31:42Z

We are moving from Travis CI to Circle CI: https://circleci.com/docs/2.0/faq/#can-i-use-ipv6-in-my-tests

…rt on Linux containers.

gerickson · 2020-05-14T05:07:46Z

Enabling IPv6 worked here, but failed here because of lack of sudo.

gerickson · 2020-05-14T06:17:32Z

Some possible clues here: https://github.com/prometheus/blackbox_exporter/blob/master/.circleci/config.yml

gerickson · 2020-05-14T06:19:37Z

Some possible clues here: https://github.com/prometheus/blackbox_exporter/blob/master/.circleci/config.yml

@woody-apple, based on that example, I think the implication here is that the only way to use Docker is to manually launch Docker containers through the machine executor rather than launching them through the Docker executor.

woody-apple · 2020-05-14T06:30:39Z

Yeah, once we get our plan upgraded tomorrow so it's not glacially slow, I'll take some stabs at this. Apologies for the delay.

turon · 2020-06-26T22:27:10Z

Here is another article on setting up IPv6 on docker (including minimum version requirements):
https://collabnix.com/enabling-ipv6-functionality-for-docker-and-docker-compose/

And this article describes how to setup Docker in CircleCI within a machine executor so you have access to /etc/docker/daemon.json file:
https://circleci.com/docs/2.0/building-docker-images/

NOTE: currently when you ssh into a fully sandboxed CircleCI docker, there is no /etc/docker folder at all.

It seems #803 is actually a working solution that resolves the issue using machine executor approach.

woody-apple · 2020-06-30T23:18:11Z

@andy31415 @gerickson - is this OK to close, now that #1372 is in?

gerickson requested review from anush-apple, BroderickCarlin, chrisdecenzo, hawk248, jelderton, robszewczyk, tpmanley and woody-apple as code owners April 24, 2020 17:26

restyled-io bot mentioned this pull request Apr 24, 2020

Restyle Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #503

Closed

restyled-io bot mentioned this pull request Apr 24, 2020

Restyle Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #507

Closed

BroderickCarlin requested a review from saurabhst April 25, 2020 04:17

BroderickCarlin reviewed Apr 25, 2020

View reviewed changes

BroderickCarlin approved these changes Apr 25, 2020

View reviewed changes

saurabhst approved these changes Apr 25, 2020

View reviewed changes

gerickson marked this pull request as draft April 27, 2020 19:28

gerickson changed the title ~~Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI~~ WIP: Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI Apr 27, 2020

gerickson force-pushed the user/gerickson/github-issue-323-and-329 branch from 5abde8e to 6ccf92e Compare April 27, 2020 19:39

Grant Erickson added 7 commits May 13, 2020 20:54

Move TestInet{EndPoint,LayerDNS}.

7226024

Added Travis CI 'before_install' hook and script to enable IPv6 suppo…

d70c7bf

…rt on Linux containers.

Incorporate 'shellharden' and 'shfmt' changes.

aae53df

2nd attempt at enabling IPv6 for Travis CI on Linux with Docker.

8204f6a

Incorporate 'shfmt' changes.

41dd54d

Managing docker requires super user support.

7633f6f

Fixed a copy-and-paste typo.

a65ef9e

Grant Erickson added 2 commits May 13, 2020 21:21

Attempt to enable local IPv6 support for Docker.

441fd3b

Remove defunct Travis CI support.

c8166f3

gerickson force-pushed the user/gerickson/github-issue-323-and-329 branch from 70f5913 to c8166f3 Compare May 14, 2020 04:21

turon mentioned this pull request Jun 26, 2020

CI support for unit tests requiring IPv6 (switched main build to vm execution instead of docker) #803

Closed

woody-apple added build issue testing tools labels Jun 30, 2020

gerickson closed this Jun 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #500

WIP: Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #500

gerickson commented Apr 24, 2020

gerickson commented Apr 24, 2020 •

edited

Loading

gerickson commented Apr 24, 2020

gerickson commented Apr 24, 2020

BroderickCarlin Apr 25, 2020

rwalker-apple commented Apr 25, 2020

gerickson commented Apr 27, 2020

gerickson commented May 11, 2020

gerickson commented May 14, 2020

gerickson commented May 14, 2020

gerickson commented May 14, 2020

woody-apple commented May 14, 2020

turon commented Jun 26, 2020 •

edited

Loading

woody-apple commented Jun 30, 2020

WIP: Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #500

WIP: Attempt to Reenable TestInet{EndPoint,LayerDNS} for CI #500

Conversation

gerickson commented Apr 24, 2020

Problem

Summary of Changes

gerickson commented Apr 24, 2020 • edited Loading

gerickson commented Apr 24, 2020

gerickson commented Apr 24, 2020

BroderickCarlin Apr 25, 2020

Choose a reason for hiding this comment

rwalker-apple commented Apr 25, 2020

gerickson commented Apr 27, 2020

gerickson commented May 11, 2020

gerickson commented May 14, 2020

gerickson commented May 14, 2020

gerickson commented May 14, 2020

woody-apple commented May 14, 2020

turon commented Jun 26, 2020 • edited Loading

woody-apple commented Jun 30, 2020

gerickson commented Apr 24, 2020 •

edited

Loading

turon commented Jun 26, 2020 •

edited

Loading