Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run shellcheck on run_clang.sh #50

Merged
merged 1 commit into from
Mar 13, 2020
Merged

run shellcheck on run_clang.sh #50

merged 1 commit into from
Mar 13, 2020

Conversation

rwalker-apple
Copy link
Contributor

No description provided.

woody-apple
woody-apple approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your shell-fu is better than mine :)

@gerickson
Copy link
Contributor

@turon, I think you'll want to advise on this one relative to your pending autotools PR and how that would impact how this functions.

@woody-apple
Copy link
Contributor

@turon, I think you'll want to advise on this one relative to your pending autotools PR and how that would impact how this functions.

Would be great to sync up about that. This action posts updates to PRs, which I like as part of the flow...

@rwalker-apple
Copy link
Contributor Author

@turon, I think you'll want to advise on this one relative to your pending autotools PR and how that would impact how this functions.

Would be great to sync up about that. This action posts updates to PRs, which I like as part of the flow...

we'll eventually have to invoke the make system for this, as clang-tidy apparently needs all the preproc defns and includes...

@woody-apple
Copy link
Contributor

@turon, I think you'll want to advise on this one relative to your pending autotools PR and how that would impact how this functions.

Would be great to sync up about that. This action posts updates to PRs, which I like as part of the flow...

we'll eventually have to invoke the make system for this, as clang-tidy apparently needs all the preproc defns and includes...

Totally fine with that, more just saying that I want to keep the clang-tidy check called out specifically as part of the PR workflow. Just like restyled.io will do clang-format

@woody-apple woody-apple merged commit ab58f0c into project-chip:master Mar 13, 2020
@rwalker-apple rwalker-apple deleted the shellcheck branch March 13, 2020 18:41
fkjagodzinski pushed a commit to fkjagodzinski/connectedhomeip that referenced this pull request Feb 17, 2021
@pan-
Merge pull request project-chip#50 from lukgni/shell_example_time
01916cf 
Add 'date' command to mbed shell example.
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Sep 12, 2022
@jmartinez-silabs
Pull request project-chip#50: MG24 wifi - Add the build flag manually.
3bfd3ca 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox Oct 6, 2022
@jmartinez-silabs @mkardous-silabs
Pull request #50: MG24 wifi - Add the build flag manually.
8795973 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@jmartinez-silabs
Pull request project-chip#50: MG24 wifi - Add the build flag manually.
20f1717 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Oct 24, 2022
@jmartinez-silabs
Pull request #50: MG24 wifi - Add the build flag manually.
145281b 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@jmartinez-silabs
Pull request #50: MG24 wifi - Add the build flag manually.
66460f7 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@jmartinez-silabs
Pull request project-chip#50: MG24 wifi - Add the build flag manually.
1e67528 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
@M201370367 M201370367 mentioned this pull request Oct 25, 2023
Open
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@jmartinez-silabs
Pull request project-chip#50: MG24 wifi - Add the build flag manually.
40da62a 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
@JasonClark2 JasonClark2 mentioned this pull request Apr 3, 2024
Open
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@jmartinez-silabs
Pull request project-chip#50: MG24 wifi - Add the build flag manually.
c8e3a6b 
Merge in WMN_TOOLS/matter from fix_build_mg24wifi to silabs

Squashed commit of the following:

commit 7195af0c6cbac15a6ce9b739aeb6a1814cb00341
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:25:26 2022 -0400

    same change for the lock app

commit 640669214f9f18bc1c67fd620a3ef5f1e6f840de
Author: Junior Martinez <[email protected]>
Date:   Wed Aug 17 15:10:25 2022 -0400

    Fix my mistake, the hardcoded disable is only for rev A. this will need to be fix in .gn for later releases
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 17, 2024
@mkardous-silabs
Merge csa branch into main branch (project-chip#50)
d4aa9a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @gerickson @woody-apple @BroderickCarlin