Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Thread ULA addresses to the lwip interface #4053

Merged
merged 1 commit into from
Dec 2, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -178,17 +178,7 @@ void GenericThreadStackManagerImpl_OpenThread_LwIP<ImplClass>::UpdateThreadInter
// - link-local addresses.
// - mesh-local addresses that are NOT RLOC addresses.
// - global unicast addresses.
//
// This logic purposefully leaves out CHIP fabric ULAs, as well as other non-fabric ULAs that the
// Thread stack assigns due to Thread SLAAC.
//
// Assignments of CHIP fabric ULAs to the netif address table are handled separately by the WARM module.
//
// Non-fabric ULAs are ignored entirely as they are presumed to not be of interest to CHIP-enabled
// devices, and would otherwise consume slots in the LwIP address table, potentially leading to
// starvation.
if (otAddr->mValid && !otAddr->mRloc &&
(!addr.IsIPv6ULA() || IsOpenThreadMeshLocalAddress(Impl()->OTInstance(), addr)))
if (otAddr->mValid && !otAddr->mRloc)
{
ip_addr_t lwipAddr = addr.ToLwIPAddr();
s8_t addrIdx;
Expand Down