Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exchange manager test to not NewPairing on an uninitialized SecureSessionManager. #3933

Closed

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Tests fail because of a bad interaction between #3640 and #3923

Summary of Changes

Fix test to initialize the object before using it.

@bzbarsky-apple bzbarsky-apple added hotfix urgent fix needed, can bypass review and removed hotfix urgent fix needed, can bypass review labels Nov 19, 2020
@bzbarsky-apple
Copy link
Contributor Author

I do wonder why this was not failing in CI, just locally. That seems pretty odd.

@bzbarsky-apple
Copy link
Contributor Author

It wasn't failing in CI because we were reading out of bounds memory, so the behavior was random. #3940 will fix that.

@bzbarsky-apple
Copy link
Contributor Author

@jelderton @mspang @andy31415 Please take a look?

@bzbarsky-apple
Copy link
Contributor Author

Looks like this got fixed in #3704

@bzbarsky-apple bzbarsky-apple deleted the fix-TestExchangeMgr branch November 21, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants