Fix exchange manager test to not NewPairing on an uninitialized SecureSessionManager. #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
added
hotfix
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
rwalker-apple
approved these changes
Nov 19, 2020
|
I do wonder why this was not failing in CI, just locally. That seems pretty odd. |
|
It wasn't failing in CI because we were reading out of bounds memory, so the behavior was random. #3940 will fix that. |
saurabhst
approved these changes
Nov 20, 2020
bzbarsky-apple
force-pushed
the
fix-TestExchangeMgr
branch
from
f9ca0e2 to
594b956
Compare
|
@jelderton @mspang @andy31415 Please take a look? |
jelderton
approved these changes
Nov 20, 2020
|
Looks like this got fixed in #3704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests fail because of a bad interaction between #3640 and #3923
Summary of Changes
Fix test to initialize the object before using it.