[Silabs] Continue WifiInterface headers clean up #37107

mkardous-silabs · 2025-01-17T15:28:46Z

Description

The goal of the PR is to continue the clean up of the WifiInterface header files aiming for a clean interface. The main focus was finishing the first version of the WiseconnectWifiInterface header.

Move code duplicated implementations from the rs9116 and SiWx wifi interface implementations to the WiseconnectWifiInterface
Clean up function names and documentation to be inline with the Silabs Matter standard
Remove Wf200 paltform duplicated platform state checks that were split between the wifi_extra member and the sl_wfx_context state.

PR adds several TODOs that will be addressed in a follow since they require the class inheritance structure and to avoid growing this PR out of hand.

Testing

Built al the NCP (wf200, rs9116, SiWx) combos and the SoC ( BRD4338A )
Commissioned the wf200, rs9116 and SoC (BRD4338A) and sent a few commands
Tested power cycle reconnection

semanticdiff-com · 2025-01-17T15:28:49Z

Review changes with

github-actions · 2025-01-17T15:44:14Z

PR #37107: Size comparison from 4fd7215 to 8be646b

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`4fd7215`	`8be646b`	change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1093164	1093164	0
			RAM	103362	103362	0
bl702	lighting-app	bl702+eth	FLASH	651226	651226	0
			RAM	25365	25365	0
		bl702+wifi	FLASH	829150	829150	0
			RAM	14105	14105	0
		bl706+mfd+rpc+littlefs	FLASH	`1056180`	`1056180`	0
			RAM	23957	23957	0
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	889150	889150	0
			RAM	18636	18636	0
	lighting-app	bl702l+mfd+littlefs	FLASH	972164	972164	0
			RAM	16484	16484	0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838436	838436	0
			RAM	123536	123536	0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823832	823832	0
			RAM	125416	125416	0
	pump-app	LP_EM_CC1354P10_6	FLASH	771112	771112	0
			RAM	113908	113908	0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755308	755308	0
			RAM	114108	114108	0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538789	538789	0
			RAM	205296	205296	0
	lock	CC3235SF_LAUNCHXL	FLASH	572677	572677	0
			RAM	205432	205432	0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	679889	679889	0
			RAM	78604	78604	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	699733	699733	0
			RAM	81244	81244	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	699733	699733	0
			RAM	81244	81244	0
		CYW930739M2EVB-02	unknown	2040	2040	0
			FLASH	656677	656677	0
			RAM	73672	73672	0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	616257	616257	0
			RAM	71588	71588	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	635893	635893	0
			RAM	74132	74132	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	635893	635893	0
			RAM	74132	74132	0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	635721	635721	0
			RAM	74596	74596	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	655429	655429	0
			RAM	77140	77140	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	655429	655429	0
			RAM	77140	77140	0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	612229	612229	0
			RAM	68692	68692	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	632089	632089	0
			RAM	71324	71324	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	632089	632089	0
			RAM	71324	71324	0
efr32	lock-app	BRD4187C	FLASH	935080	935080	0
			RAM	160004	160004	0
		BRD4338a	FLASH	730852	730932	80
			RAM	234844	234844	0
	window-app	BRD4187C	FLASH	1030520	1030520	0
			RAM	128112	128112	0
esp32	all-clusters-app	c3devkit	DRAM	95192	95192	0
			FLASH	1538592	1538592	0
			IRAM	82552	82552	0
		m5stack	DRAM	116172	116172	0
			FLASH	1545810	1545810	0
			IRAM	117039	117039	0
linux	air-purifier-app	debug	unknown	4752	4752	0
			FLASH	2710313	2710313	0
			RAM	133096	133096	0
	all-clusters-app	debug	unknown	5560	5560	0
			FLASH	5976378	5976378	0
			RAM	531880	531880	0
	all-clusters-minimal-app	debug	unknown	5456	5456	0
			FLASH	5324396	5324396	0
			RAM	242992	242992	0
	bridge-app	debug	unknown	5472	5472	0
			FLASH	`4682624`	`4682624`	0
			RAM	221744	221744	0
	chip-tool	debug	unknown	5984	5984	0
			FLASH	13045274	13045274	0
			RAM	596634	596634	0
	chip-tool-ipv6only	arm64	unknown	21816	21816	0
			FLASH	11125760	11125760	0
			RAM	648168	648168	0
	fabric-admin	debug	unknown	5808	5808	0
			FLASH	11392249	11392249	0
			RAM	596978	596978	0
	fabric-bridge-app	debug	unknown	4728	4728	0
			FLASH	4507674	4507674	0
			RAM	208880	208880	0
	fabric-sync	debug	unknown	4968	4968	0
			FLASH	5610469	5610469	0
			RAM	483656	483656	0
	lighting-app	debug+rpc+ui	unknown	6136	6136	0
			FLASH	5617953	5617953	0
			RAM	232008	232008	0
	lock-app	debug	unknown	5408	5408	0
			FLASH	4732582	4732582	0
			RAM	207976	207976	0
	ota-provider-app	debug	unknown	4768	4768	0
			FLASH	4361282	4361282	0
			RAM	201696	201696	0
	ota-requestor-app	debug	unknown	4720	4720	0
			FLASH	4498956	4498956	0
			RAM	206280	206280	0
	shell	debug	unknown	4248	4248	0
			FLASH	`3006765`	`3006765`	0
			RAM	160736	160736	0
	thermostat-no-ble	arm64	unknown	9568	9568	0
			FLASH	`4102232`	`4102232`	0
			RAM	246224	246224	0
	tv-app	debug	unknown	5736	5736	0
			FLASH	5950645	5950645	0
			RAM	607088	607088	0
	tv-casting-app	debug	unknown	5312	5312	0
			FLASH	11273101	11273101	0
			RAM	711064	711064	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	914772	914772	0
			RAM	143176	143176	0
		nrf7002dk_nrf5340_cpuapp	FLASH	890116	890116	0
			RAM	141363	141363	0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	849492	849492	0
			RAM	142088	142088	0
nxp	contact	k32w0+release	FLASH	584456	584456	0
			RAM	70960	70960	0
		mcxw71+release	FLASH	600000	600000	0
			RAM	63176	63176	0
	light	k32w0+release	FLASH	611204	611204	0
			RAM	70352	70352	0
		k32w1+release	FLASH	685744	685744	0
			RAM	48768	48768	0
	lock	mcxw71+release	FLASH	761776	761776	0
			RAM	70788	70788	0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1648060	1648060	0
			RAM	211624	211624	0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	`1554628`	`1554628`	0
			RAM	208448	208448	0
	light	cy8ckit_062s2_43012	FLASH	`1470172`	`1470172`	0
			RAM	200416	200416	0
	lock	cy8ckit_062s2_43012	FLASH	1468028	1468028	0
			RAM	224760	224760	0
qpg	lighting-app	qpg6105+debug	FLASH	662560	662560	0
			RAM	105296	105296	0
	lock-app	qpg6105+debug	FLASH	620228	620228	0
			RAM	99748	99748	0
stm32	light	STM32WB5MM-DK	FLASH	483240	483240	0
			RAM	144752	144752	0
telink	bridge-app	tlsr9258a	FLASH	682280	682280	0
			RAM	91092	91092	0
	contact-sensor-app	tlsr9528a_retention	FLASH	622460	622460	0
			RAM	31492	31492	0
	light-app-ota-compress-lzma-shell-factory-data	tl3218x	FLASH	771348	771348	0
			RAM	49352	49352	0
	light-app-ota-shell-factory-data	tl7218x	FLASH	775952	775952	0
			RAM	99656	99656	0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709734	709734	0
			RAM	73384	73384	0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626898	626898	0
			RAM	142024	142024	0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	812962	812962	0
			RAM	99568	99568	0
tizen	all-clusters-app	arm	unknown	5132	5132	0
			FLASH	1755320	1755320	0
			RAM	93680	93680	0
	chip-tool-ubsan	arm	unknown	11044	11044	0
			FLASH	18216926	18216926	0
			RAM	7958632	7958632	0

examples/platform/silabs/BaseApplication.cpp

examples/platform/silabs/MatterConfig.cpp

src/platform/silabs/DiagnosticDataProviderImpl.cpp

src/platform/silabs/SiWx917/SiWxPlatformInterface.h

src/platform/silabs/wifi/SiWx/WifiInterfaceImpl.cpp

src/platform/silabs/wifi/rs911x/WifiInterfaceImpl.cpp

src/platform/silabs/wifi/wf200/WifiInterfaceImpl.cpp

examples/platform/silabs/BaseApplication.cpp

src/platform/silabs/ConfigurationManagerImpl.cpp

src/platform/silabs/wifi/wf200/WifiInterfaceImpl.cpp

src/platform/silabs/wifi/wiseconnect-interface/WiseconnectWifiInterface.h

andy31415

Mostly consensus-approval as this is platform-specific. Leaving up to silabs folks for functionality review.

github-actions · 2025-01-20T15:25:21Z

PR #37107: Size comparison from 4fd7215 to 49041f1

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`4fd7215`	`49041f1`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1093164	`1092532`	-632	-0.1
			RAM	103362	103386	24	0.0
bl702	lighting-app	bl702+eth	FLASH	651226	650750	-476	-0.1
			RAM	25365	25365	0	0.0
		bl702+wifi	FLASH	829150	828618	-532	-0.1
			RAM	14105	14097	-8	-0.1
		bl706+mfd+rpc+littlefs	FLASH	`1056180`	1055648	-532	-0.1
			RAM	23957	23949	-8	-0.0
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	889150	888646	-504	-0.1
			RAM	18636	18628	-8	-0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	972164	971632	-532	-0.1
			RAM	16484	16484	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838436	838196	-240	-0.0
			RAM	123536	123560	24	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823832	823632	-200	-0.0
			RAM	125416	125432	16	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	771112	770800	-312	-0.0
			RAM	113908	113916	8	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755308	755060	-248	-0.0
			RAM	114108	114132	24	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538789	538509	-280	-0.1
			RAM	205296	205304	8	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572677	572421	-256	-0.0
			RAM	205432	205440	8	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679889	679577	-312	-0.0
			RAM	78604	78628	24	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699733	699429	-304	-0.0
			RAM	81244	81260	16	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699733	699429	-304	-0.0
			RAM	81244	81260	16	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656677	656357	-320	-0.0
			RAM	73672	73696	24	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	616257	615977	-280	-0.0
			RAM	71588	71604	16	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635893	635605	-288	-0.0
			RAM	74132	74156	24	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635893	635605	-288	-0.0
			RAM	74132	74156	24	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635721	635473	-248	-0.0
			RAM	74596	74612	16	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	655429	655181	-248	-0.0
			RAM	77140	77164	24	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	655429	655181	-248	-0.0
			RAM	77140	77164	24	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	612229	611949	-280	-0.0
			RAM	68692	68700	8	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	632089	631809	-280	-0.0
			RAM	71324	71340	16	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	632089	631809	-280	-0.0
			RAM	71324	71340	16	0.0
efr32	lock-app	BRD4187C	FLASH	935080	934760	-320	-0.0
			RAM	160004	160000	-4	-0.0
		BRD4338a	FLASH	730852	730660	-192	-0.0
			RAM	234844	234848	4	0.0
	window-app	BRD4187C	FLASH	1030520	1030320	-200	-0.0
			RAM	128112	128108	-4	-0.0
esp32	all-clusters-app	c3devkit	DRAM	95192	95208	16	0.0
			FLASH	1538592	`1537224`	-1368	-0.1
			IRAM	82552	82552	0	0.0
		m5stack	DRAM	116172	116196	24	0.0
			FLASH	1545810	`1544862`	-948	-0.1
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4752	4752	0	0.0
			FLASH	2710313	`2710247`	-66	-0.0
			RAM	133096	133240	144	0.1
	all-clusters-app	debug	unknown	5560	5560	0	0.0
			FLASH	5976378	`5975792`	-586	-0.0
			RAM	531880	531960	80	0.0
	all-clusters-minimal-app	debug	unknown	5456	5456	0	0.0
			FLASH	5324396	`5323840`	-556	-0.0
			RAM	242992	243104	112	0.0
	bridge-app	debug	unknown	5472	5472	0	0.0
			FLASH	`4682624`	`4682566`	-58	-0.0
			RAM	221744	221824	80	0.0
	chip-tool	debug	unknown	5984	5984	0	0.0
			FLASH	13045274	13045286	12	0.0
			RAM	596634	596634	0	0.0
	chip-tool-ipv6only	arm64	unknown	21816	21816	0	0.0
			FLASH	11125760	11125792	32	0.0
			RAM	648168	648168	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11392249	11392261	12	0.0
			RAM	596978	596978	0	0.0
	fabric-bridge-app	debug	unknown	4728	4728	0	0.0
			FLASH	4507674	4507710	36	0.0
			RAM	208880	209008	128	0.1
	fabric-sync	debug	unknown	4968	4968	0	0.0
			FLASH	5610469	5610517	48	0.0
			RAM	483656	483768	112	0.0
	lighting-app	debug+rpc+ui	unknown	6136	6136	0	0.0
			FLASH	5617953	5617665	-288	-0.0
			RAM	232008	232072	64	0.0
	lock-app	debug	unknown	5408	5408	0	0.0
			FLASH	4732582	4732450	-132	-0.0
			RAM	207976	208056	80	0.0
	ota-provider-app	debug	unknown	4768	4768	0	0.0
			FLASH	4361282	4361302	20	0.0
			RAM	201696	201808	112	0.1
	ota-requestor-app	debug	unknown	4720	4720	0	0.0
			FLASH	4498956	`4498772`	-184	-0.0
			RAM	206280	206392	112	0.1
	shell	debug	unknown	4248	4248	0	0.0
			FLASH	`3006765`	3006173	-592	-0.0
			RAM	160736	160832	96	0.1
	thermostat-no-ble	arm64	unknown	9568	9576	8	0.1
			FLASH	`4102232`	4102584	352	0.0
			RAM	246224	246336	112	0.0
	tv-app	debug	unknown	5736	5736	0	0.0
			FLASH	5950645	`5950037`	-608	-0.0
			RAM	607088	607200	112	0.0
	tv-casting-app	debug	unknown	5312	5312	0	0.0
			FLASH	11273101	11273005	-96	-0.0
			RAM	711064	711192	128	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	914772	913764	-1008	-0.1
			RAM	143176	143196	20	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	890116	888984	-1132	-0.1
			RAM	141363	141383	20	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	849492	848636	-856	-0.1
			RAM	142088	142108	20	0.0
nxp	contact	k32w0+release	FLASH	584456	584448	-8	-0.0
			RAM	70960	70976	16	0.0
		mcxw71+release	FLASH	600000	599816	-184	-0.0
			RAM	63176	63192	16	0.0
	light	k32w0+release	FLASH	611204	610844	-360	-0.1
			RAM	70352	70376	24	0.0
		k32w1+release	FLASH	685744	685376	-368	-0.1
			RAM	48768	48784	16	0.0
	lock	mcxw71+release	FLASH	761776	761456	-320	-0.0
			RAM	70788	70812	24	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1648060	1647236	-824	-0.0
			RAM	211624	211640	16	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	`1554628`	1553836	-792	-0.1
			RAM	208448	208456	8	0.0
	light	cy8ckit_062s2_43012	FLASH	`1470172`	1469788	-384	-0.0
			RAM	200416	200440	24	0.0
	lock	cy8ckit_062s2_43012	FLASH	1468028	`1467740`	-288	-0.0
			RAM	224760	224776	16	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662560	662112	-448	-0.1
			RAM	105296	105312	16	0.0
	lock-app	qpg6105+debug	FLASH	620228	619892	-336	-0.1
			RAM	99748	99772	24	0.0
stm32	light	STM32WB5MM-DK	FLASH	483240	482752	-488	-0.1
			RAM	144752	144768	16	0.0
telink	bridge-app	tlsr9258a	FLASH	682280	681742	-538	-0.1
			RAM	91092	91112	20	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	622460	621910	-550	-0.1
			RAM	31492	31512	20	0.1
	light-app-ota-compress-lzma-shell-factory-data	tl3218x	FLASH	771348	770772	-576	-0.1
			RAM	49352	49372	20	0.0
	light-app-ota-shell-factory-data	tl7218x	FLASH	775952	775192	-760	-0.1
			RAM	99656	99676	20	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709734	709134	-600	-0.1
			RAM	73384	73404	20	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626898	626138	-760	-0.1
			RAM	142024	142044	20	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	812962	812202	-760	-0.1
			RAM	99568	99588	20	0.0
tizen	all-clusters-app	arm	unknown	5132	5132	0	0.0
			FLASH	1755320	`1755408`	88	0.0
			RAM	93680	93732	52	0.1
	chip-tool-ubsan	arm	unknown	11044	11044	0	0.0
			FLASH	18216926	18216942	16	0.0
			RAM	7958632	7958632	0	0.0

mkardous-silabs added 4 commits January 16, 2025 17:16

Clean up Wifi Interface headers

f357f6d

Rename SiWx function

9852f20

fix comment

6b60ed0

fix build

8be646b

mkardous-silabs requested a review from a team as a code owner January 17, 2025 15:28

mkardous-silabs changed the title ~~[Silabs] Continue WifiInterface header clean up~~ [Silabs] Continue WifiInterface headers clean up Jan 17, 2025

pullapprove bot added the review - pending label Jan 17, 2025

github-actions bot added examples scripts platform silabs labels Jan 17, 2025

jmartinez-silabs reviewed Jan 17, 2025

View reviewed changes

rosahay-silabs reviewed Jan 20, 2025

View reviewed changes

Address review comments

49041f1

andy31415 approved these changes Jan 20, 2025

View reviewed changes

jmartinez-silabs approved these changes Jan 20, 2025

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Jan 20, 2025

mergify bot merged commit f19f44a into project-chip:master Jan 20, 2025
69 checks passed

mkardous-silabs deleted the feature/continue_refactor branch January 20, 2025 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Silabs] Continue WifiInterface headers clean up #37107

[Silabs] Continue WifiInterface headers clean up #37107

mkardous-silabs commented Jan 17, 2025

semanticdiff-com bot commented Jan 17, 2025

github-actions bot commented Jan 17, 2025 •

edited

Loading

andy31415 left a comment

github-actions bot commented Jan 20, 2025 •

edited

Loading

[Silabs] Continue WifiInterface headers clean up #37107

[Silabs] Continue WifiInterface headers clean up #37107

Conversation

mkardous-silabs commented Jan 17, 2025

Description

Testing

semanticdiff-com bot commented Jan 17, 2025

github-actions bot commented Jan 17, 2025 • edited Loading

andy31415 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 20, 2025 • edited Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025 •

edited

Loading