Decouple ember functions from wifi diagnostic cluster #37097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yufengwangca
force-pushed
the
pr/cluster/dgwifi
branch
from
350a3a2 to
8fdecff
Compare
|
PR #37097: Size comparison from 61fe32f to 8fdecff Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
changed the title
yufengwangca
force-pushed
the
pr/cluster/dgwifi
branch
from
8fdecff to
dc90b55
Compare
|
PR #37097: Size comparison from 593861d to dc90b55 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
joonhaengHeo
approved these changes
Jan 18, 2025
src/app/clusters/wifi-network-diagnostics-server/wifi-network-diagnostics-server.cpp
Show resolved
Hide resolved
src/app/clusters/wifi-network-diagnostics-server/wifi-network-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
|
PR #37097: Size comparison from 593861d to ad4a162 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jan 21, 2025
yufengwangca
added a commit
to yufengwangca/connectedhomeip
that referenced
this pull request
Jan 22, 2025
…7097) * Decouple ember functions from general diagnostic cluster * Address review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple WiFi Network Diagnostic Cluster from ember and migrate to use CHI (CommandHandlerInterface) instead
Fix: #36892
Testing
Verified with manual pairing and CI