CADMIN_1_19.py: Do not try to remove on non commissioned controller #36989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is adding a new controller to the fids array which has the effect that the next loop will try to also read from this controller, but the test expects commissioning to fail, so this will not work. The test currently does not fail because of another problem which is not addressed 8yet) by this PR and is in discussion. To see the effect of this change the used controller need to have more fabrics allowed then the used chip-app - currently because both have same limit of 17 this is failing already on controller instance creation which never added the controller to the fids array.
|
Review changes with |
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36989: Size comparison from dedef1f to 0f53823 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jan 9, 2025
|
Issue for second part: project-chip/matter-test-scripts#473 |
|
PR #36989: Size comparison from d3204f6 to 0056ae8 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is adding a new controller to the fids array which has the effect that the next loop will try to also read from this controller, but the test expects commissioning to fail, so this will not work.
The test currently does not fail because of another problem (see project-chip/matter-test-scripts#473) which is not addressed (yet) by this PR and is in discussion. To see the effect of this change the used controller need to have more fabrics allowed then the used chip-app - currently because both have same limit of 17 this is failing already on controller instance creation which never added the controller to the fids array.