Create a SpanSearchValue class that allows tree-searching without extra intermediate if null/missing checks.
#36754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36754: Size comparison from 84fb78f to e413adf Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36754: Size comparison from 6447c64 to 95bdb5e Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
…omeip into fluent_search_class
|
PR #36754: Size comparison from 8606290 to 6b03605 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
changed the title
FluentTreeObject class that allows tree-searching without extra intermediate if null/missing checks.SpanSearchValue class that allows tree-searching without extra intermediate if null/missing checks.
|
PR #36754: Size comparison from 577074c to ce68521 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36754: Size comparison from 577074c to 57fc226 Full report (3 builds for cc32xx, stm32)
|
|
PR #36754: Size comparison from 577074c to 2aa7c96 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36754: Size comparison from c799e5c to 9315ba1 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Dec 11, 2024
bzbarsky-apple
approved these changes
Dec 13, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36754: Size comparison from c799e5c to 6103ce4 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our data model will often have levels:
endpointscontainclusterswhich containattributes(or commands clusters contain device types or semantic tags etc.) and code of finding endpoint ->cluster->attribute is highly repetitive.Looking to have some fluent search capability equivalent to a
?.elvis operator (see https://kotlinlang.org/docs/null-safety.html#elvis-operator for example) that saysdo this if not null, otherwise preserve the null.This is also similar to what optionals usually do for
maportransform(https://doc.rust-lang.org/std/option/enum.Option.html#method.map , https://en.cppreference.com/w/cpp/utility/optional/transform which we do not yet have in C++17)This allows me to do:
AttributeMeta *meta = tree .Find<ByEndpointId>(123) .Find<ByClusterId>(234) .Next<ByAttributeId>(345) .Value();to be the equivalent of something like:
with the added benefit that it enforces consistent usage of
search hintsand potentially repetitive bits removal (e.g. top level find by endpoint/cluster would be repeated in many functions dealing with full attribute paths, so even though this is a template object the end result may be less code rather than more).