Move src/app/codegen-data-model-provider to src/data-model-providers/codegen
#36752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… within app directly
|
Review changes with |
tcarmelveilleux
approved these changes
Dec 6, 2024
|
PR #36752: Size comparison from 45f544b to a7a678d Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Dec 6, 2024
|
PR #36752: Size comparison from 45f544b to 051cbd8 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #36752: Size comparison from 45f544b to 241c6f7 Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
andy31415
force-pushed
the
move_codegen_provider
branch
from
241c6f7 to
cbbc96f
Compare
|
PR #36752: Size comparison from 84fb78f to cbbc96f Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Dec 6, 2024
pidarped
approved these changes
Dec 9, 2024
|
Since this is a pure rename, moving forward with this after a few days of review time since other changes on the DataModel::Provider interface would conflict with these changes. |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…rs/codegen` (project-chip#36752) * Move codegen provider to data-model-providers/codegen to not place it within app directly * Restyle * Fix paths with minimal change --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect us to have several
Providersincluding:As such, I created
src/data-model-providersto be a separate source thansrc/appsince src/app seems to generally be the interaction model engine. It is still somewhat unfortunate thatsrc/utilis not split out as someemberbit, however changing that seems more challanging. Looking to change providers only at this point.