python testing: Allow top-level PICS with automated selectors #36727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this was originally written the idea was that the TH would run these tests unconditionally and the test itself would indicate if it ran. This works well in the CI and we still want to maintain this mechanism since it will allow us to automate test selection more easily down the road. However, the time required to even start a test in the TH is significant. With the way the test harness is set up currently, adding unconditional tests adds a significant amount of time to testing, even if the tests don't run. For now, let's bring back at least cluster-level gating. We can still gate internally on cluster elements for the CI. This isn't ideal, but it's where we are now.
|
Review changes with Changed Files
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36727: Size comparison from ca772d7 to e041b81 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Dec 11, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…t-chip#36727) When this was originally written the idea was that the TH would run these tests unconditionally and the test itself would indicate if it ran. This works well in the CI and we still want to maintain this mechanism since it will allow us to automate test selection more easily down the road. However, the time required to even start a test in the TH is significant. With the way the test harness is set up currently, adding unconditional tests adds a significant amount of time to testing, even if the tests don't run. For now, let's bring back at least cluster-level gating. We can still gate internally on cluster elements for the CI. This isn't ideal, but it's where we are now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this was originally written the idea was that the TH would run these tests unconditionally and the test itself would indicate if it ran. This works well in the CI and we still want to maintain this mechanism since it will allow us to automate test selection more easily down the road.
However, the time required to even start a test in the TH is significant. With the way the test harness is set up currently, adding unconditional tests adds a significant amount of time to testing, even if the tests don't run. For now, let's bring back at least cluster-level gating. We can still gate internally on cluster elements for the CI. This isn't ideal, but it's where we are now.