[darwin-framework-tool] Update CHIPToolKeyPair implementation to not … #36723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
kiel-apple
reviewed
Dec 4, 2024
examples/darwin-framework-tool/commands/common/CHIPToolKeypair.h
Outdated
Show resolved
Hide resolved
|
PR #36723: Size comparison from 38ad07d to 6f97678 Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
vivien-apple
force-pushed
the
DFT_KeyPairWithObjCAPI
branch
from
6f97678 to
b3a22a6
Compare
kiel-apple
approved these changes
Dec 4, 2024
bzbarsky-apple
approved these changes
Dec 4, 2024
|
Fast-tracking platform-specific fix with platform owner review. |
vivien-apple
force-pushed
the
DFT_KeyPairWithObjCAPI
branch
from
b3a22a6 to
518faff
Compare
|
PR #36723: Size comparison from e419e33 to 518faff Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
…use matter sdk specific APIs but native APIS
vivien-apple
force-pushed
the
DFT_KeyPairWithObjCAPI
branch
from
518faff to
6597d72
Compare
|
PR #36723: Size comparison from b0fd385 to 6597d72 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36723: Size comparison from 6063e23 to dd8bc40 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…use matter sdk specific APIs but native APIS (project-chip#36723)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…use matter sdk specific APIs but native APIS
Problem
The
darwin-framework-toolkey pair generation is using APIs from theC++sdk instead of native APIs.This PR convert the appropriate code to use native APIs.