Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC_WHM_2_1: Fix incorrect --aplication argument #36578

Merged
merged 1 commit into from
Nov 20, 2024
Merged

TC_WHM_2_1: Fix incorrect --aplication argument #36578

merged 1 commit into from
Nov 20, 2024

Conversation

soares-sergio
Copy link
Contributor

@soares-sergio soares-sergio commented Nov 20, 2024 •
edited
Loading

It should be water-heater instead of evse.

The reason this test doesn't fail in ToT is that the current energy-management example app instantiates "too many clusters" for either app. For example, even when the app/argument selected is evse it still initializes the some of the water-heater functionality, which is enough to make that test pass.

Meanwhile, in #36201 I hit this test failure in CI because I split that app to initialize only what's required for each app.

@soares-sergio
TC_WHM_2_1: Fix incorrect --aplication argument
6c2b3d6 
It should be `water-heater` instead of `evse`.
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 20, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/python_testing/TC_WHM_2_1.py  0% smaller

@github-actions github-actions bot added tests matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 labels Nov 20, 2024
@soares-sergio soares-sergio mentioned this pull request Nov 20, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

PR #36578: Size comparison from 007f4d7 to 6c2b3d6

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 007f4d7 6c2b3d6 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350102 1350102 0 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649704 649704 0 0.0
RAM 25329 25329 0 0.0
bl702+wifi FLASH 827028 827028 0 0.0
RAM 14069 14069 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055226 1055226 0 0.0
RAM 23909 23909 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976856 976856 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838044 838044 0 0.0
RAM 123632 123632 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823968 823968 0 0.0
RAM 125520 125520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770700 770700 0 0.0
RAM 113988 113988 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754904 754904 0 0.0
RAM 114196 114196 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629046 629046 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667626 667626 0 0.0
RAM 205936 205936 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679657 679657 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699501 699501 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699501 699501 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656437 656437 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616505 616505 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636141 636141 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636141 636141 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635969 635969 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655677 655677 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655677 655677 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612461 612461 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632313 632313 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632313 632313 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 927796 927796 0 0.0
RAM 160164 160164 0 0.0
BRD4338a FLASH 744088 744080 -8 -0.0
RAM 233296 233296 0 0.0
window-app BRD4187C FLASH 1019216 1019208 -8 -0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1541396 1541396 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116264 116264 0 0.0
FLASH 1550046 1550046 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4712 4712 0 0.0
FLASH 2706051 2706051 0 0.0
RAM 129736 129736 0 0.0
all-clusters-app debug unknown 5552 5552 0 0.0
FLASH 5997154 5997154 0 0.0
RAM 523464 523464 0 0.0
all-clusters-minimal-app debug unknown 5448 5448 0 0.0
FLASH 5335408 5335408 0 0.0
RAM 242520 242520 0 0.0
bridge-app debug unknown 5432 5432 0 0.0
FLASH 4675126 4675126 0 0.0
RAM 218464 218464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12834316 12834316 0 0.0
RAM 582226 582226 0 0.0
chip-tool-ipv6only arm64 unknown 21304 21304 0 0.0
FLASH 10969472 10969472 0 0.0
RAM 633160 633160 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11243259 11243259 0 0.0
RAM 582610 582610 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4499396 4499396 0 0.0
RAM 205424 205424 0 0.0
fabric-sync debug unknown 4896 4896 0 0.0
FLASH 5595957 5595957 0 0.0
RAM 472392 472392 0 0.0
lighting-app debug+rpc+ui unknown 6096 6096 0 0.0
FLASH 5611073 5611073 0 0.0
RAM 228616 228616 0 0.0
lock-app debug unknown 5368 5368 0 0.0
FLASH 4724482 4724482 0 0.0
RAM 204632 204632 0 0.0
ota-provider-app debug unknown 4744 4744 0 0.0
FLASH 4350000 4350000 0 0.0
RAM 198304 198304 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4488434 4488434 0 0.0
RAM 202888 202888 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 3020317 3020317 0 0.0
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4095872 4095872 0 0.0
RAM 243000 243000 0 0.0
tv-app debug unknown 5664 5664 0 0.0
FLASH 5947669 5947669 0 0.0
RAM 595920 595920 0 0.0
tv-casting-app debug unknown 5232 5232 0 0.0
FLASH 11039837 11039837 0 0.0
RAM 691960 691960 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916040 916040 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888340 888340 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850240 850240 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 584312 584312 0 0.0
RAM 71048 71048 0 0.0
mcxw71+release FLASH 598840 598840 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 611220 611220 0 0.0
RAM 70440 70440 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748720 748720 0 0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1643988 1643988 0 0.0
RAM 212072 212072 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551972 1551972 0 0.0
RAM 208872 208872 0 0.0
light cy8ckit_062s2_43012 FLASH 1467012 1467012 0 0.0
RAM 200848 200848 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465188 1465188 0 0.0
RAM 225208 225208 0 0.0
qpg lighting-app qpg6105+debug FLASH 662320 662320 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620436 620436 0 0.0
RAM 99836 99836 0 0.0
stm32 light STM32WB5MM-DK FLASH 483128 483128 0 0.0
RAM 144848 144848 0 0.0
telink bridge-app tlsr9258a FLASH 681516 681516 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621964 621964 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762810 762810 0 0.0
RAM 50208 50208 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709096 709096 0 0.0
RAM 73460 73460 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625794 625794 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811702 811702 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4972 4972 0 0.0
FLASH 1726500 1726500 0 0.0
RAM 90652 90652 0 0.0
chip-tool-ubsan arm unknown 10780 10780 0 0.0
FLASH 17946894 17946894 0 0.0
RAM 7830432 7830432 0 0.0

@mergify mergify bot merged commit e1fbaf6 into project-chip:master Nov 20, 2024
67 checks passed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Nov 25, 2024
@soares-sergio @shgutte
TC_WHM_2_1: Fix incorrect --aplication argument (project-chip#36578)
cafb7e4 
It should be `water-heater` instead of `evse`.
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@soares-sergio @yyzhong-g
TC_WHM_2_1: Fix incorrect --aplication argument (project-chip#36578)
41195f0 
It should be `water-heater` instead of `evse`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soares-sergio @andy31415 @arkq