[Fabric-Sync] Set remote bridge after reverse pair the bridge device #36509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yufengwangca
force-pushed
the
pr/fs/reverse
branch
from
3edc8b8 to
272fe8c
Compare
yufengwangca
force-pushed
the
pr/fs/reverse
branch
from
272fe8c to
fad5df5
Compare
|
PR #36509: Size comparison from 57489d1 to fad5df5 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Nov 15, 2024
|
PR #36509: Size comparison from 57489d1 to e553540 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Nov 18, 2024
jmartinez-silabs
approved these changes
Nov 18, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…roject-chip#36509) * Set remote bridge after reverse pair the bridge device * Address review comment
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#36509) * Set remote bridge after reverse pair the bridge device * Address review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After complete fabric sync setup process from E1 to E2, we not only need to setup the remote fabric bridge in E1, but also need to setup the remote bridge in E2. Otherwise, we can only sync device from E2 to E1, not the other direction.
This is the fix ported from #36451