-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool[darwin-framework-tool] Using ComplexArgument leaks on syntax failure and even on success #36227
Open
vivien-apple
wants to merge
3
commits into
project-chip:master
Choose a base branch
from
vivien-apple:DFR_LeakWhenUsingComplexArgument
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[chip-tool[darwin-framework-tool] Using ComplexArgument leaks on syntax failure and even on success #36227
vivien-apple
wants to merge
3
commits into
project-chip:master
from
vivien-apple:DFR_LeakWhenUsingComplexArgument
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay result into a leak
… may not be cleared properly
Review changes with SemanticDiff. |
vivien-apple
changed the title
Dfr leak when using complex argument
[chip-tool[darwin-framework-tool] Using ComplexArgument leaks on syntax failure and even on success
Oct 24, 2024
PR #36227: Size comparison from 9423a8c to 7e75b69 Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
PR #36227: Size comparison from 71170fe to 0a67d53 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using a
ComplexArgument
either viachip-tool
or viadarwin-framework-tool
, may results into a leak if the argument is malformed.For example:
This one leaks too even if it works: