da_revocation: align the revocation set generation algorithm with spec changes #36225
+197
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 18% smaller than the GitHub diff.
|
|
PR #36225: Size comparison from 75d7e6b to 7b138c4 Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36225: Size comparison from 75d7e6b to c4a854b Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
reviewed
Oct 24, 2024
| @@ -91,6 +91,101 @@ def parse_vid_pid_from_distinguished_name(distinguished_name): | |||
| return vid, pid | |||
|
|
|||
|
|
|||
| def get_akid(cert: x509.Certificate) -> bytes: | |||
There was a problem hiding this comment.
Since you are catching the exception, the bytes output should be optional here.
Comment on lines
+494
to
+496
| # No point in creating an entry which has no revoked serial numbers | ||
| if len(serialnumber_list) == 0: | ||
| continue |
There was a problem hiding this comment.
Let's generate 1 set for each, even if empty.
| # will raise an exception if signature is invalid | ||
| try: | ||
| root.public_key().verify(cert.signature, cert.tbs_certificate_bytes, ec.ECDSA(cert.signature_hash_algorithm)) | ||
| except Exception: |
There was a problem hiding this comment.
This is too wide of an exception. Please catch the exception that the verification fails with.
| @@ -91,6 +91,101 @@ def parse_vid_pid_from_distinguished_name(distinguished_name): | |||
| return vid, pid | |||
|
|
|||
|
|
|||
| def get_akid(cert: x509.Certificate) -> bytes: | |||
There was a problem hiding this comment.
-> Optional[bytes]`
Requires from typing import Optional
| try: | ||
| return cert.extensions.get_extension_for_oid(x509.OID_SUBJECT_KEY_IDENTIFIER).value.key_identifier | ||
| except Exception: | ||
| return None |
There was a problem hiding this comment.
Please log in all exceptions what happened to help assist debugging.
| return None | ||
|
|
||
|
|
||
| def get_skid(cert: x509.Certificate) -> bytes: |
There was a problem hiding this comment.
Same here, missing optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been some updates to the revocation set generation algorithm in https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/10308.
Add some helper function to interact with certificates.
Tests
Locally tested