-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric-Sync] Initial version of fabric-sync example #36136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 2 of 12 files.
|
PR #36136: Size comparison from 76e9e14 to f23a1c3 Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fs/app
branch
from
October 18, 2024 16:46
2e4c959
to
225d970
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 18, 2024
PR #36136: Size comparison from 728d138 to 225d970 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Oct 18, 2024
yufengwangca
force-pushed
the
pr/fs/app
branch
from
October 18, 2024 19:43
225d970
to
340289c
Compare
PR #36136: Size comparison from 00bd828 to 340289c Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Oct 18, 2024
yufengwangca
force-pushed
the
pr/fs/app
branch
from
October 18, 2024 21:35
03864ea
to
76a1c15
Compare
PR #36136: Size comparison from 29a567e to 76a1c15 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
FergusHuang
pushed a commit
to FergusHuang/connectedhomeip
that referenced
this pull request
Oct 20, 2024
tehampson
reviewed
Oct 21, 2024
tehampson
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, conducting fabric synchronization requires running two separate example apps, Fabric-Admin and Fabric-Bridge-app, on each side. When integrating into the actual product, these apps are expected to run on the same physical device. This poses a challenge for certain products, especially those based on RTOS systems that do not support multiple processes, making it difficult to properly isolate the two apps.
To address this issue, we plan to develop a new FabricSync example app that combines the functionality of both Fabric-Admin and Fabric-Bridge-app within a single application, using a single process with a shared event loop.
This is the initial version of the FabricSync example app which function as both a Commissioner and a Commissionee simultaneously. Both roles will operate within the same process and utilize a shared event loop, allowing the application to handle events for both roles within a unified framework. This design leverages Matter's event-driven architecture, where a single event loop manages various network, system, and protocol events, regardless of whether the device acts as a Commissioner or Commissionee.
You can commission another instance of fabric-sync app running on another machine using the following command
controller commission-onnetwork 20202021 3840 192.168.86.246 5540