Auto-release group iterators #36127
Merged
Auto-release group iterators #36127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
arkq
approved these changes
Oct 17, 2024
|
PR #36127: Size comparison from dead378 to 9f6ed73 Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, stm32, tizen)
|
Co-authored-by: Arkadiusz Bokowy <[email protected]>
|
PR #36127: Size comparison from dead378 to dac20cc Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Fix up group iterator releasing * Add missing bracket * Renames and comments * Restyled by clang-format * Update src/app/WriteHandler.cpp Co-authored-by: Arkadiusz Bokowy <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Arkadiusz Bokowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group iteration logic had
VerifyOrExitthat could have bypassed group iterator releasing, which could leak memory on error paths.Fixed this and also moved the variables to be closer to the declaration size.