Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tv-casting-app fix CloseCommissioningWindow upon unexpected CDC Commi… #35984

Merged
merged 4 commits into from
Oct 10, 2024
Merged

tv-casting-app fix CloseCommissioningWindow upon unexpected CDC Commi… #35984

merged 4 commits into from
Oct 10, 2024

Conversation

pgregorr-amazon
Copy link
Contributor

@pgregorr-amazon pgregorr-amazon commented Oct 9, 2024 •
edited
Loading

A fix for Github [BUG] Can't connect Android CHPTVCastingApp with Android MatterTvServer #33842:
#33842

Change summary

  1. Updated connectedhomeip/examples/tv-casting-app/tv-casting-common/core/CommissionerDeclarationHandler.cpp to only close the commissioning window upon CDC CommissionerDeclaration message with CommissionerPasscode == true or CancelPasscode == true. The client should handle CDC CommissionerDeclaration ErrorCode appropriately.

Testing
Verified and tested locally with the Linux, Android and iOS tv-casting-app example mobile apps, and the Linux tv-app (CastingPlayer). Able to build and commission with the example apps using both the commissionee and commissioner generated passcode flows.

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 9, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 3 files.

Overall, the semantic diff is 87% smaller than the GitHub diff.

Filename Status
❔ examples/tv-casting-app/tv-casting-common/core/CommissionerDeclarationHandler.cpp Unsupported file format
❔ examples/tv-casting-app/linux/simple-app-helper.cpp Unsupported file format
✔️ examples/tv-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java 86.66% smaller

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

PR #35984: Size comparison from af3727b to acda3d3

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section af3727b acda3d3 change % change
bl602 lighting-app bl602 FLASH 1280626 1280626 0 0.0
RAM 95808 95808 0 0.0
bl602+mfd FLASH 1308674 1308674 0 0.0
RAM 95464 95464 0 0.0
bl602+rpc FLASH 1335302 1335302 0 0.0
RAM 103784 103784 0 0.0
bl702 lighting-app bl702 FLASH 945052 945052 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957506 957506 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051210 1051210 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658184 658184 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824980 824980 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961988 961988 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974750 974750 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829348 829348 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814672 814672 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761236 761236 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745464 745464 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616978 616978 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657074 657074 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678317 678317 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698169 698169 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698169 698169 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655097 655097 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614653 614653 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634289 634289 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634289 634289 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633965 633965 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653681 653681 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653681 653681 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609269 609269 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629129 629129 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629129 629129 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933860 933860 0 0.0
RAM 135876 135876 0 0.0
lock-app BRD2605a FLASH 740264 740256 -8 -0.0
RAM 230248 230248 0 0.0
BRD4338a FLASH 740912 740904 -8 -0.0
RAM 230280 230280 0 0.0
window-app BRD4187C FLASH 1017264 1017264 0 0.0
RAM 127812 127812 0 0.0
esp32 all-clusters-app c3devkit DRAM 94088 94088 0 0.0
FLASH 1538452 1538452 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548914 1548914 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2780123 2780123 0 0.0
RAM 129488 129488 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6084120 6084120 0 0.0
RAM 512416 512416 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5417370 5417370 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4750844 4750844 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12673638 12673638 0 0.0
RAM 563410 563410 0 0.0
chip-tool-ipv6only arm64 unknown 20736 20736 0 0.0
FLASH 11307376 11307376 0 0.0
RAM 613728 613728 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11019607 11019607 0 0.0
RAM 563066 563066 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4574040 4574040 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5691425 5691425 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4800406 4800406 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4429830 4429830 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4568644 4568644 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3110173 3110173 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4318432 4318432 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6028309 6028309 0 0.0
RAM 585952 585952 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10870877 10870877 0 0.0
RAM 651888 651888 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914252 914252 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885056 885056 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847668 847668 0 0.0
RAM 141101 141101 0 0.0
nxp contact k32w0+release FLASH 582008 582008 0 0.0
RAM 70792 70792 0 0.0
k32w1+release FLASH 596712 596712 0 0.0
RAM 63016 63016 0 0.0
mcxw71+release FLASH 596472 596472 0 0.0
RAM 63016 63016 0 0.0
light k32w0+release FLASH 618572 618572 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682712 682712 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682712 682712 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705056 705056 0 0.0
RAM 67156 67156 0 0.0
mcxw71+release FLASH 705064 705064 0 0.0
RAM 67156 67156 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646148 1646148 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552212 1552212 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467684 1467684 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464756 1464756 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660344 660344 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618356 618356 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481640 481640 0 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620746 620746 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687944 687944 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780936 780936 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680842 680842 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620510 620510 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708452 708452 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625448 625448 0 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811208 811208 0 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656416 656416 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696820 696820 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634144 634144 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611334 611334 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627660 627660 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653466 653466 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 638066 638066 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524204 524204 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725936 1725936 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10456 10456 0 0.0
FLASH 17544794 17544794 0 0.0
RAM 7642532 7642532 0 0.0

andy31415
andy31415 previously requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: moving of targetCastingPlayer to the top of the function when we tolerate non-null seems to be more brittle.

@andy31415 andy31415 requested a review from a team October 9, 2024 13:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

PR #35984: Size comparison from af3727b to 83b031e

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section af3727b 83b031e change % change
bl602 lighting-app bl602 FLASH 1280626 1280626 0 0.0
RAM 95808 95808 0 0.0
bl602+mfd FLASH 1308674 1308674 0 0.0
RAM 95464 95464 0 0.0
bl602+rpc FLASH 1335302 1335302 0 0.0
RAM 103784 103784 0 0.0
bl702 lighting-app bl702 FLASH 945052 945052 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957506 957506 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051210 1051210 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658184 658184 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824980 824980 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961988 961988 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974750 974750 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829348 829348 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814672 814672 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761236 761236 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745464 745464 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616978 616978 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657074 657074 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678317 678317 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698169 698169 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698169 698169 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655097 655097 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614653 614653 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634289 634289 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634289 634289 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633965 633965 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653681 653681 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653681 653681 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609269 609269 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629129 629129 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629129 629129 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933860 934128 268 0.0
RAM 135876 135876 0 0.0
lock-app BRD2605a FLASH 740264 740272 8 0.0
RAM 230248 230600 352 0.2
BRD4338a FLASH 740912 740920 8 0.0
RAM 230280 230632 352 0.2
window-app BRD4187C FLASH 1017264 1017564 300 0.0
RAM 127812 127812 0 0.0
esp32 all-clusters-app c3devkit DRAM 94088 94088 0 0.0
FLASH 1538452 1538484 32 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548914 1548938 24 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2780123 2780123 0 0.0
RAM 129488 129488 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6084120 6084120 0 0.0
RAM 512416 512416 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5417370 5417370 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4750844 4750844 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12673638 12673638 0 0.0
RAM 563410 563410 0 0.0
chip-tool-ipv6only arm64 unknown 20736 20736 0 0.0
FLASH 11307376 11307376 0 0.0
RAM 613728 613728 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11019607 11019607 0 0.0
RAM 563066 563066 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4574040 4574040 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5691425 5691425 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4800406 4800406 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4429830 4429830 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4568644 4568644 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3110173 3110173 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4318432 4318432 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6028309 6028309 0 0.0
RAM 585952 585952 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10870877 10870877 0 0.0
RAM 651888 651888 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914252 914252 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885056 885056 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847668 847668 0 0.0
RAM 141101 141101 0 0.0
nxp contact k32w0+release FLASH 582008 582008 0 0.0
RAM 70792 70792 0 0.0
k32w1+release FLASH 596712 596784 72 0.0
RAM 63016 63016 0 0.0
mcxw71+release FLASH 596472 596536 64 0.0
RAM 63016 63016 0 0.0
light k32w0+release FLASH 618572 618572 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682712 682784 72 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682712 682784 72 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705056 705128 72 0.0
RAM 67156 67156 0 0.0
mcxw71+release FLASH 705064 705136 72 0.0
RAM 67156 67156 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646148 1646148 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552212 1552212 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467684 1467684 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464756 1464756 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660344 660344 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618356 618356 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481640 481640 0 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620746 620746 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687944 687944 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780936 780936 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680842 680842 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620510 620510 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708452 708452 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625448 625448 0 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811208 811208 0 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656416 656416 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696820 696820 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634144 634144 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611334 611334 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627660 627660 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653466 653466 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 638066 638066 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524204 524204 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725936 1725936 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10456 10456 0 0.0
FLASH 17544794 17544794 0 0.0
RAM 7642532 7642532 0 0.0

@andy31415 andy31415 dismissed their stale review October 9, 2024 20:42

changes made

@pgregorr-amazon pgregorr-amazon requested a review from a team as a code owner October 10, 2024 00:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

PR #35984: Size comparison from af3727b to 9c196b2

Increases above 0.2%:

platform target config section af3727b 9c196b2 change % change
linux all-clusters-app debug RAM 512416 514720 2304 0.4
chip-tool debug FLASH 12673638 12779836 106198 0.8
RAM 563410 567890 4480 0.8
chip-tool-ipv6only arm64 unknown 20736 20880 144 0.7
FLASH 11307376 11396256 88880 0.8
RAM 613728 618432 4704 0.8
fabric-admin debug FLASH 11019607 11090809 71202 0.6
RAM 563066 567578 4512 0.8
tv-app debug RAM 585952 588256 2304 0.4
tv-casting-app debug FLASH 10870877 10979229 108352 1.0
RAM 651888 656960 5072 0.8
tizen chip-tool-ubsan arm unknown 10456 10528 72 0.7
FLASH 17544794 17717818 173024 1.0
RAM 7642532 7714500 71968 0.9
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section af3727b 9c196b2 change % change
bl602 lighting-app bl602 FLASH 1280626 1280856 230 0.0
RAM 95808 95808 0 0.0
bl602+mfd FLASH 1308674 1308902 228 0.0
RAM 95464 95464 0 0.0
bl602+rpc FLASH 1335302 1335532 230 0.0
RAM 103784 103784 0 0.0
bl702 lighting-app bl702 FLASH 945052 945236 184 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957506 957688 182 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051210 1051394 184 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658184 658368 184 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824980 825164 184 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961988 962172 184 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974750 974932 182 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829348 829460 112 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814672 814792 120 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761236 761356 120 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745464 745584 120 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616978 617114 136 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657074 657218 144 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678317 678437 120 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698169 698281 112 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698169 698281 112 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655097 655217 120 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614653 614765 112 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634289 634393 104 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634289 634393 104 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633965 634085 120 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653681 653793 112 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653681 653793 112 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609269 609389 120 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629129 629249 120 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629129 629249 120 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933860 934544 684 0.1
RAM 135876 135956 80 0.1
lock-app BRD2605a FLASH 740264 740632 368 0.0
RAM 230248 230816 568 0.2
BRD4338a FLASH 740912 741280 368 0.0
RAM 230280 230848 568 0.2
window-app BRD4187C FLASH 1017264 1018108 844 0.1
RAM 127812 127892 80 0.1
esp32 all-clusters-app c3devkit DRAM 94088 94088 0 0.0
FLASH 1538452 1538678 226 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548914 1549018 104 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2780123 2780949 826 0.0
RAM 129488 129520 32 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6084120 6085426 1306 0.0
RAM 512416 514720 2304 0.4
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5417370 5418228 858 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4750844 4751700 856 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12673638 12779836 106198 0.8
RAM 563410 567890 4480 0.8
chip-tool-ipv6only arm64 unknown 20736 20880 144 0.7
FLASH 11307376 11396256 88880 0.8
RAM 613728 618432 4704 0.8
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11019607 11090809 71202 0.6
RAM 563066 567578 4512 0.8
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4574040 4574898 858 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5691425 5692289 864 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4800406 4801264 858 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4429830 4430688 858 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4568644 4569502 858 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3110173 3111005 832 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4318432 4319472 1040 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6028309 6029621 1312 0.0
RAM 585952 588256 2304 0.4
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10870877 10979229 108352 1.0
RAM 651888 656960 5072 0.8
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914252 914420 168 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885056 885228 172 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847668 847836 168 0.0
RAM 141101 141101 0 0.0
nxp contact k32w0+release FLASH 582008 582168 160 0.0
RAM 70792 70792 0 0.0
k32w1+release FLASH 596712 596896 184 0.0
RAM 63016 63016 0 0.0
mcxw71+release FLASH 596472 596656 184 0.0
RAM 63016 63016 0 0.0
light k32w0+release FLASH 618572 618700 128 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682712 682904 192 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682712 682904 192 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705056 705248 192 0.0
RAM 67156 67156 0 0.0
mcxw71+release FLASH 705064 705256 192 0.0
RAM 67156 67156 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646148 1646292 144 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552212 1552356 144 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467684 1467828 144 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464756 1464900 144 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660344 660488 144 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618356 618508 152 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481640 481784 144 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620746 620946 200 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687944 688144 200 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780936 781136 200 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680842 681042 200 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620510 620710 200 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708452 708652 200 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625448 625648 200 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811208 811408 200 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656416 656616 200 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696820 697020 200 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634144 634344 200 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611334 611534 200 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627660 627860 200 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653466 653666 200 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 638066 638266 200 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524204 524404 200 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725936 1726732 796 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10456 10528 72 0.7
FLASH 17544794 17717818 173024 1.0
RAM 7642532 7714500 71968 0.9

@sharadb-amazon sharadb-amazon enabled auto-merge (squash) October 10, 2024 16:51
@sharadb-amazon sharadb-amazon merged commit 80a7636 into project-chip:master Oct 10, 2024
70 checks passed
@pgregorr-amazon pgregorr-amazon mentioned this pull request Oct 10, 2024
Closed
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@pgregorr-amazon @yyzhong-g
tv-casting-app fix CloseCommissioningWindow upon unexpected CDC Commi… (
001c14b 
project-chip#35984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgregorr-amazon @andy31415 @yunhanw-google @sharadb-amazon @chrisdecenzo