-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-DESC-2.2: Fix comparison when mfg label is in the list #35849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests included, also tested on an example app with mfg tags
Review changes with SemanticDiff. Analyzed 2 of 2 files.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Sep 30, 2024
PR #35849: Size comparison from 9c6c365 to fd2ba46 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 1, 2024
andy31415
approved these changes
Oct 18, 2024
tcarmelveilleux
approved these changes
Oct 18, 2024
cecille
removed
the
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
label
Oct 18, 2024
PR #35849: Size comparison from 728d138 to ee6c6ce Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
FergusHuang
pushed a commit
to FergusHuang/connectedhomeip
that referenced
this pull request
Oct 20, 2024
…ip#35849) * TC-DESC-2.2: Fix comparison when mfg label is in the list Unit tests included, also tested on an example app with mfg tags * linter * Restyled by isort --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests included, also tested on an example app with mfg tags