[Silabs] Adds fix for BTN low power mode for SiWx917 SoC and power manager #35808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
rosahay-silabs
force-pushed
the
bugfix/siwx917-sleep-btn0-fix
branch
from
5d3dda5 to
8af7b11
Compare
|
PR #35808: Size comparison from a6f44fd to 8af7b11 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35808: Size comparison from a6f44fd to f0b4baa Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rosahay-silabs
force-pushed
the
bugfix/siwx917-sleep-btn0-fix
branch
from
465c040 to
4e1d918
Compare
|
PR #35808: Size comparison from af1b0ee to 4e1d918 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
added
the
changing-submodules-on-purpose
rosahay-silabs
force-pushed
the
bugfix/siwx917-sleep-btn0-fix
branch
from
4e1d918 to
5be0a39
Compare
|
PR #35808: Size comparison from 579b1b1 to 5be0a39 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35808: Size comparison from d7abcbf to ccd1897 Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35808: Size comparison from 4269ff5 to a91f0af Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Reduce into inline functions
rosahay-silabs
force-pushed
the
bugfix/siwx917-sleep-btn0-fix
branch
from
1d84f86 to
2723c15
Compare
|
PR #35808: Size comparison from 197f698 to 4ae4cce Increases above 0.2%:
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #35808: Size comparison from 197f698 to 973467f Increases above 0.2%:
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
approved these changes
Oct 24, 2024
…to bugfix/siwx917-sleep-btn0-fix
andy31415
approved these changes
Nov 5, 2024
|
PR #35808: Size comparison from c05110f to 3391cca Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35808: Size comparison from c05110f to 735fd76 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…nager (project-chip#35808) * Decouple UART power requirement handler * Adds refactored BTN handler based on power manager * Fixed incorrect API * Adds changes for interrupt * Replace use of RSI_xx APIs with sl_si91x_xx APIs * Refactor button event handling and UART power requirement handler * Adds comments based on the coding standards Reduce into inline functions * Renaming sl_btn0 -> btn0 * Adds changes to optimize code * Adds CPP define in header * Update function comments * Replace with more readable condition * Updates document to add BTN0 screen cycle action (project-chip#323) * Restyled by prettier-markdown * Adds compilation fix for EFR32 boards * Addressing comments --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After integrating the power manager on the SiWx917 SoC, sometimes when the BTN 0 is pressed there is no change in the QR code and there is a delay in factory reset as well i.e., taking more than 5 seconds to factory reset the device.