[Tizen] Run tests from 9P-shared directory instead of ISO follow-up #35786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 42 files. Overall, the semantic diff is 11% smaller than the GitHub diff. File Information
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35786: Size comparison from 90b0fd2 to 23f5fc3 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
requested changes
Sep 26, 2024
arkq
reviewed
Sep 26, 2024
arkq
reviewed
Sep 26, 2024
Co-authored-by: Arkadiusz Bokowy <[email protected]>
arkq
added
the
changing-submodules-on-purpose
|
PR #35786: Size comparison from 90b0fd2 to e447a91 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Sep 26, 2024
|
PR #35786: Size comparison from 648f088 to d4925a1 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 26, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#35786) * Remove ISO. Add virtfs sharing * Remove ISO. Add sharing. Copy runner * Update .tpk path * Expand argument description * Use generic target name * Bump image version for workflows * More verbose description Co-authored-by: Arkadiusz Bokowy <[email protected]> --------- Co-authored-by: Arkadiusz Bokowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently the way tests and runner are passed onto QEMU is by mounting an iso image containing these. The problem with this approach is that building the image is slow, and does not allow to share output files back with host which will be needed in a follow-up PR adding code coverage for tests.
Solution
Scalable and efficient method is to share tests directory between host and QEMU using virtfs with 9P. This approach involves copying adequate runner to
${root_out_dir}/testsand then sharing it as/mnt/chipon QEMU side. This is highly configurable as the new optiontizen_qemu.py --sharetakes a custom path. A service is added which performs the mounting.Testing
Tested locally using both interactive and non-interactive modes with and without customized shared directory.
Extra notes
This PR contains non-Dockerfile changes for the mentioned above issue and solution as they were merged previously (#35745).