[Chef] Set all attributes to NVM if they are qualified for nonVolatile #35785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Chef] Set all attributes to NVM if they are qualified for nonVolitile
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtov-sfy
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #35785: Size comparison from 90b0fd2 to 1922bbf Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
And remove noip_rootnode_dimmablelight_bCwGYSDpoe.zap
|
PR #35785: Size comparison from 90b0fd2 to 789cb2a Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 26, 2024
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Sep 27, 2024
project-chip#35785) * [Chef] Set all attributes to NVM [Chef] Set all attributes to NVM if they are qualified for nonVolitile * Add all changed matter files due to ZAP change And remove noip_rootnode_dimmablelight_bCwGYSDpoe.zap * Add corresponding changed matter files * Add corresponding matter changed files due to zap change
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Sep 30, 2024
Add the python tools for updating attributes to NVM: project-chip#35785
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
project-chip#35785) * [Chef] Set all attributes to NVM [Chef] Set all attributes to NVM if they are qualified for nonVolitile * Add all changed matter files due to ZAP change And remove noip_rootnode_dimmablelight_bCwGYSDpoe.zap * Add corresponding changed matter files * Add corresponding matter changed files due to zap change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Chef] Set all attributes to NVM if they are qualified for
nonVolatileWe need to keep the attribute changed value even after Chef application restart. So all the attributes are updated to NVM if they are qualified for
nonVolatile. The checking criteria is based on the data_model https://github.com/project-chip/connectedhomeip/tree/master/data_model/1.3/clusters if the attribute haspersistence="nonVolatile"