[Darwin] Implement delegate add/remove for device controller #35475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35475: Size comparison from 7249c56 to 40106d1 Full report (43 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35475: Size comparison from 7249c56 to 7f72353 Full report (44 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, stm32, tizen)
|
|
PR #35475: Size comparison from 7249c56 to 9079581 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Sep 9, 2024
jtung-apple
force-pushed
the
jtung/darwin-devicecontroller-add-remove-delegates
branch
from
9079581 to
b01863a
Compare
|
PR #35475: Size comparison from 607a4a8 to b01863a Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jtung-apple
force-pushed
the
jtung/darwin-devicecontroller-add-remove-delegates
branch
from
b01863a to
ba1a330
Compare
|
PR #35475: Size comparison from bbce050 to ba1a330 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
force-pushed
the
jtung/darwin-devicecontroller-add-remove-delegates
branch
from
ba1a330 to
df36535
Compare
|
PR #35475: Size comparison from 4aa1d59 to df36535 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…dline tool main queue blockage
|
PR #35475: Size comparison from 4aa1d59 to 98be8ea Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…-chip#35475) * [Darwin] Implement delegate add/remove for device controller * Restyled changes * Fixed setDeviceControllerDelegate * Added unit test * Restyled * Unit test fix for TSAN * Use matter queue for device controller callback queue to avoid commandline tool main queue blockage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements add/remove semantics for MTRDeviceController delegate.
The add/remove delegates will be weak references but will keep a strong reference for delegates set from the existing setDeviceControllerDelegate API, to keep old behavior.