Fix remaining post-TE2 TC-SWTCH issues #35291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tcarmelveilleux
commented
Aug 29, 2024
•
tcarmelveilleux
commented
- Fixes Fix remaining issues in TC_SWTCH.py that didn't make TE2 deadline #34656 (-2.2, -2.3 and -2.4 to better match test plan)
- Fixes [CERT-TEST-FAILURE] -TC-SWTCH-2.2 - Test failed #28620 (Better bound checks)
- Fixes [CERT-TEST-FAILURE] [TC-SWTCH-2.3, 2.4] Python script has to be aligned with Test plan. #35241
- Fixes project-chip#34556 (-2.2, -2.3 and -2.4 to better match test plan) - Fixes project-chip#28620 (Better bound checks) - Fixes project-chip#35241
|
Review changes with SemanticDiff. Analyzed 2 of 3 files. Overall, the semantic diff is 39% smaller than the GitHub diff.
|
github-actions
bot
added
examples
tests
matter-1.4-te2-script-change
|
PR #35291: Size comparison from 9a0add3 to 3074edd Full report (41 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35291: Size comparison from 9a0add3 to 35ddd3e Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35291: Size comparison from 9946fc8 to 1b22e1d Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35291: Size comparison from 815195b to 8b0836d Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Aug 31, 2024
dengpan-liu
reviewed
Sep 2, 2024
dengpan-liu
approved these changes
Sep 2, 2024
ksperling-apple
approved these changes
Sep 2, 2024
|
PR #35291: Size comparison from 7085588 to da62637 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Sep 2, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Fix remaining post-TE2 TC-SWTCH issues - Fixes project-chip#34556 (-2.2, -2.3 and -2.4 to better match test plan) - Fixes project-chip#28620 (Better bound checks) - Fixes project-chip#35241 * Restyled by clang-format * Restyled by autopep8 * Restyled by isort * Fix step 2 of TC-SWTCH--2.4 --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.