Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the crash due to packet buffers running out of space in CommandHandlerImpl. #35279

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fixed the crash due to packet buffers running out of space in CommandHandlerImpl. #35279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea62667
Fixed the crash due to packet buffers running out of space in Command…
shripad621git Aug 29, 2024
28c95ce
Update src/app/CommandHandlerImpl.h
shripad621git Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/CommandHandlerImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,12 @@ class CommandHandlerImpl : public CommandHandler
{
return CHIP_NO_ERROR;
}
ReturnErrorOnFailure(RollbackResponse());
// The error value of RollbackResponse is not important if it fails, we prioritize
// conveying the error generated by addResponseFunction to the caller.
if (RollbackResponse() != CHIP_NO_ERROR)
{
return err;
}
// If we failed to add a command due to lack of space in the
// packet, we will make another attempt to add the response using
// an additional InvokeResponseMessage.
Expand Down
Loading