Remove _invokeCommandWithEndpointID implementation from MTRDevice. #35208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35208: Size comparison from e20355a to 518ab3a Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
This is implemented (differently) by the different subclasses. Once this implementation is removed, the following become unused and can be removed: * setExpectedValues * removeExpectedValuesForAttributePaths Once those are removed, the following become unused and can be removed: * _getAttributesToReportWithNewExpectedValues * _removeExpectedValueForAttributePath Once those are removed, the following become unused and can be removed: * _setExpectedValue * expectedValueNextID At this point (since setExpectedValues was removed), the only reference to _checkExpiredExpectedValues is in _performScheduledExpirationCheck, which is only called from _checkExpiredExpectedValues. So these are both unreachable and can be removed. Then the following become unused and can be removed: * expirationCheckScheduled * _reportAttributes * _attributeDataValue * expectedValueCache And then _filteredAttributes and _filteredEvents are unused and can be removed. Then both the event and attribute versions of _interestedPaths: are unused and can be removed. At this point, the following become unused and can be removed: * MTRDeviceExpectedValueFieldIndex * MTRDeviceReadRequestFieldIndex * MTRDeviceWriteRequestFieldIndex * MTRDeviceWorkItemBatchingID * MTRDeviceWorkItemDuplicateTypeID ------------------------------------------------------------
bzbarsky-apple
force-pushed
the
mtrdevice-invoke
branch
from
518ab3a to
11cedff
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35208: Size comparison from e20355a to 11cedff Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
anush-apple
approved these changes
Aug 27, 2024
anush-apple
reviewed
Aug 27, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…roject-chip#35208) This is implemented (differently) by the different subclasses. Once this implementation is removed, the following become unused and can be removed: * setExpectedValues * removeExpectedValuesForAttributePaths Once those are removed, the following become unused and can be removed: * _getAttributesToReportWithNewExpectedValues * _removeExpectedValueForAttributePath Once those are removed, the following become unused and can be removed: * _setExpectedValue * expectedValueNextID At this point (since setExpectedValues was removed), the only reference to _checkExpiredExpectedValues is in _performScheduledExpirationCheck, which is only called from _checkExpiredExpectedValues. So these are both unreachable and can be removed. Then the following become unused and can be removed: * expirationCheckScheduled * _reportAttributes * _attributeDataValue * expectedValueCache And then _filteredAttributes and _filteredEvents are unused and can be removed. Then both the event and attribute versions of _interestedPaths: are unused and can be removed. At this point, the following become unused and can be removed: * MTRDeviceExpectedValueFieldIndex * MTRDeviceReadRequestFieldIndex * MTRDeviceWriteRequestFieldIndex * MTRDeviceWorkItemBatchingID * MTRDeviceWorkItemDuplicateTypeID ------------------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented (differently) by the different subclasses.
Once this implementation is removed, the following become unused and can be removed:
Once those are removed, the following become unused and can be removed:
Once those are removed, the following become unused and can be removed:
At this point (since setExpectedValues was removed), the only reference to _checkExpiredExpectedValues is in _performScheduledExpirationCheck, which is only called from _checkExpiredExpectedValues. So these are both unreachable and can be removed. Then the following become unused and can be removed:
And then _filteredAttributes and _filteredEvents are unused and can be removed.
Then both the event and attribute versions of _interestedPaths: are unused and can be removed.
At this point, the following become unused and can be removed: