THNETDIR and WIFINM: Align with latest spec and other small fixes #35191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 10 files. Overall, the semantic diff is 13% smaller than the GitHub diff.
|
github-actions
bot
added
tools
examples
scripts
app
tests
matter-1.4-te2-script-change
|
PR #35191: Size comparison from 05b60aa to 2cc4148 Full report (46 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
ksperling-apple
force-pushed
the
thnetdir-fixes
branch
from
2cc4148 to
1afc70d
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
ksperling-apple
force-pushed
the
thnetdir-fixes
branch
from
1afc70d to
2fcf5a5
Compare
|
PR #35191: Size comparison from acba7f8 to 2fcf5a5 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tleacmcsa
approved these changes
Aug 26, 2024
bzbarsky-apple
approved these changes
Aug 27, 2024
- Implement ActiveTimestamp check for updates - Implement CASE session requirement for GetOperationalDataset - Update / add certification YAML tests accordingly
- Implement CASE session requirement for NetworkPassphraseRequest - Add a corresponding YAML test
ksperling-apple
force-pushed
the
thnetdir-fixes
branch
from
2fcf5a5 to
f0bc2ab
Compare
|
Rebased to pick up #35206 |
|
PR #35191: Size comparison from 4c78d07 to f0bc2ab Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
marchemi
reviewed
Aug 27, 2024
marchemi
reviewed
Aug 27, 2024
marchemi
reviewed
Aug 27, 2024
marchemi
reviewed
Aug 27, 2024
marchemi
approved these changes
Aug 27, 2024
jmartinez-silabs
approved these changes
Aug 27, 2024
Co-authored-by: marchemi <[email protected]>
|
PR #35191: Size comparison from 4c78d07 to 217a1f1 Increases above 0.2%:
Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
Instead, disable the test in CI for darwin-framework-tool. Fixes matter-test-scripts#359
|
PR #35191: Size comparison from 4c78d07 to 0bdb406 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
…oject-chip#35191) * YAML runner: Add support for EstablishPASESession command * Enable python constraints in TC_THNETDIR_* * THNETDIR: Align with latest spec - Implement ActiveTimestamp check for updates - Implement CASE session requirement for GetOperationalDataset - Update / add certification YAML tests accordingly * WIFINM: Implement CASE session requirement for NetworkPassphraseRequest - Implement CASE session requirement for NetworkPassphraseRequest - Add a corresponding YAML test * Apply test script suggestions from code review Co-authored-by: marchemi <[email protected]> * Enable negative timed-invoke tests in TC_THNETDIR_2_2 Instead, disable the test in CI for darwin-framework-tool. Fixes matter-test-scripts#359 --------- Co-authored-by: marchemi <[email protected]>
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…oject-chip#35191) * YAML runner: Add support for EstablishPASESession command * Enable python constraints in TC_THNETDIR_* * THNETDIR: Align with latest spec - Implement ActiveTimestamp check for updates - Implement CASE session requirement for GetOperationalDataset - Update / add certification YAML tests accordingly * WIFINM: Implement CASE session requirement for NetworkPassphraseRequest - Implement CASE session requirement for NetworkPassphraseRequest - Add a corresponding YAML test * Apply test script suggestions from code review Co-authored-by: marchemi <[email protected]> * Enable negative timed-invoke tests in TC_THNETDIR_2_2 Instead, disable the test in CI for darwin-framework-tool. Fixes matter-test-scripts#359 --------- Co-authored-by: marchemi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns implementation with https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10295
Fixes project-chip/matter-test-scripts#359