Added TC-ACL-2-11 test script #35163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
github-actions
bot
added
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
auto-merge was automatically disabled
August 27, 2024 20:49
Head branch was pushed to by a user without write access
|
PR #35163: Size comparison from d705323 to 2b920f3 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
requested changes
Aug 27, 2024
There was a problem hiding this comment.
- Introduce check that ARL doesn't apply to critical elements where it should not apply (e.g. every descriptor across the node, and possibly at least 1 featuremap on every single cluster of the node)
- Add CI detection argument to avoid long wait for the 1 hour wait
tcarmelveilleux
approved these changes
Aug 27, 2024
Are the follow-ups tracked on another PR? And will they be for 1.4? Follow ups:
|
|
PR #35163: Size comparison from 5bff3a5 to f98eedb Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
robertfarnum
approved these changes
Aug 28, 2024
|
PR #35163: Size comparison from 5bff3a5 to ca29dab Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
The follow-up test script changes would fall out of updates to the test plan. Do we need another issue for the test script, or just let the test plan issue cover it all? |
auto-merge was automatically disabled
August 28, 2024 14:27
Head branch was pushed to by a user without write access
|
PR #35163: Size comparison from 5bff3a5 to 61d4218 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
Implement the M-ACL / Managed NIM / ARL test plan. The test plan (currently in review form) can be found here: CHIP-Specifications/chip-test-plans#4316 -------- * Added TC-ACL-2-11 test script * Restyled by autopep8 * Restyled by isort * fixed linter issues * review updates * Use network-manager-app for TC_ACL_2_11.py * Fix REPL build commands for network manager * add trace support to network-manager-app --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the M-ACL / Managed NIM / ARL test plan.
The test plan (currently in review form) can be found here:
https://github.com/CHIP-Specifications/chip-test-plans/pull/4316