-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TimeoutMs to KeepActive command #35154
Merged
tehampson
merged 5 commits into
project-chip:master
from
tehampson:timeoutms-added-to-keep-active
Aug 27, 2024
Merged
Adding TimeoutMs to KeepActive command #35154
tehampson
merged 5 commits into
project-chip:master
from
tehampson:timeoutms-added-to-keep-active
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 5 of 16 files. Overall, the semantic diff is 1% smaller than the GitHub diff.
|
tehampson
commented
Aug 22, 2024
src/app/zap-templates/zcl/data-model/chip/bridged-device-basic-information.xml
Show resolved
Hide resolved
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
August 22, 2024 16:11
PR #35154: Size comparison from 58896ab to 9aa72f8 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35154: Size comparison from 2695601 to 7187d72 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Aug 23, 2024
PR #35154: Size comparison from 2695601 to 28489e3 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
commented
Aug 23, 2024
cecille
approved these changes
Aug 23, 2024
src/app/zap-templates/zcl/data-model/chip/bridged-device-basic-information.xml
Outdated
Show resolved
Hide resolved
saurabhst
approved these changes
Aug 23, 2024
bzbarsky-apple
approved these changes
Aug 23, 2024
src/app/zap-templates/zcl/data-model/chip/bridged-device-basic-information.xml
Outdated
Show resolved
Hide resolved
yufengwangca
approved these changes
Aug 26, 2024
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being added in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10298