tv-casting-app fixed 32-bit vs 64-bit formatting issue #34866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34866: Size comparison from befc990 to 6f09140 Full report (19 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
sharadb-amazon
previously requested changes
Aug 8, 2024
examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp
Show resolved
Hide resolved
kiel-apple
reviewed
Aug 8, 2024
examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp
Outdated
Show resolved
Hide resolved
kiel-apple
reviewed
Aug 8, 2024
examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Kiel Oleson <[email protected]>
woody-apple
approved these changes
Aug 8, 2024
|
PR #34866: Size comparison from befc990 to 3a8a103 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
see followup in #34869 |
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…34866) * tv-casting-app fixed 32-bit vs 64-bit formatting issue * Apply suggestions from code review Co-authored-by: Kiel Oleson <[email protected]> * Restyled by clang-format --------- Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Kiel Oleson <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In connectedhomeip/examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp
To ensure compatibility across both 32-bit and 64-bit platforms, using the %zu format specifier for size_t values, which are returned by the size() methods of STL containers. This approach is platform-independent and will work correctly on both 32-bit and 64-bit systems.