TBRM: Add missing PendingDatasetTimestamp attribute and CASE session check #34768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 8 of 33 files. File Information
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo and
chshu
...p/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
Outdated
Show resolved
Hide resolved
ksperling-apple
approved these changes
Aug 5, 2024
|
You'll need to update the zap file for the Network Manager example app (by opening it in ZAP and ensuring the PendingDatasetTimestamp attribute is enabled) for the builds to pass. Also update the |
|
PR #34768: Size comparison from bbef51a to a067fc4 Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
github-actions
bot
added
examples
matter-1.4-te2-script-change
|
PR #34768: Size comparison from bbef51a to 690ca3e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34768: Size comparison from bbef51a to 3468f0a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34768: Size comparison from bbef51a to d0c5c4e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
marchemi
approved these changes
Aug 6, 2024
marchemi
approved these changes
Aug 6, 2024
chrisdecenzo
approved these changes
Aug 6, 2024
examples/network-manager-app/network-manager-common/network-manager-app.zap
Show resolved
Hide resolved
bzbarsky-apple
previously requested changes
Aug 7, 2024
...p/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
Outdated
Show resolved
Hide resolved
...p/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
dismissed
their stale review
Error propagation is no longer broken.
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…check (project-chip#34768) * TBRM: Add missing PendingDatasetTimestamp attribute and CASE session check * review change * zap regenerate and update the Test_TC_TBRM_2_1.yaml * Restyled by clang-format * Read function error map to IM-space error * Add attribute report for PendingDatasetTimestamp * review changes --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the PendingDatasetTimestamp to ThreadBorderRouterManagement cluster and add CASE session check for SetDataset commands.
Fixes #34751