-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dependency error and some changed requested by reviewer #34764
Open
crlonxp
wants to merge
19
commits into
project-chip:master
Choose a base branch
from
crlonxp:nan-usd-te2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+733
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
crlonxp
commented
Aug 3, 2024
- Change the default setting of WiFiPAF as enabled if running on Linux system
- Change to use C++ casting
- Move the paf cancel function from destructor to shutdown
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
August 3, 2024 12:03
crlonxp
force-pushed
the
nan-usd-te2
branch
2 times, most recently
from
October 14, 2024 11:09
2673a44
to
3e2d05b
Compare
PR #34764: Size comparison from 9524ac9 to 3e2d05b Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34764: Size comparison from 9524ac9 to e17f0f2 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Change the default setting of WiFiPAF as enabled if running on Linux system * Change to use C++ casting * Move the paf cancel function from desctructor to shutdown Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
… the string Signed-off-by: Lo,Chin-Ran <[email protected]>
…a_supplicant Signed-off-by: Lo,Chin-Ran <[email protected]>
…ipaf is not selected Signed-off-by: Lo,Chin-Ran <[email protected]>
…o on ipv6 Signed-off-by: Lo,Chin-Ran <[email protected]>
PR #34764: Size comparison from 75d7e6b to a7a761a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.