Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dependency error and some changed requested by reviewer #34764

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Fix the dependency error and some changed requested by reviewer #34764

wants to merge 19 commits into from
+733 −253

Conversation

crlonxp
Copy link
Contributor

@crlonxp crlonxp commented Aug 3, 2024

  • Change the default setting of WiFiPAF as enabled if running on Linux system
  • Change to use C++ casting
  • Move the paf cancel function from destructor to shutdown

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@crlonxp crlonxp force-pushed the nan-usd-te2 branch 2 times, most recently from 2673a44 to 3e2d05b Compare October 14, 2024 11:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

PR #34764: Size comparison from 9524ac9 to 3e2d05b

Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 9524ac9 3e2d05b change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349682 1349682 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647742 647742 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825228 825228 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053858 1053858 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974998 974998 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829532 829532 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814872 814872 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761436 761436 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745664 745664 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617154 617154 0 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657258 657258 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678517 678517 0 0.0
RAM 78668 78668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698361 698361 0 0.0
RAM 81300 81300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698361 698361 0 0.0
RAM 81300 81300 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655297 655297 0 0.0
RAM 73736 73736 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614845 614845 0 0.0
RAM 71628 71628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634473 634473 0 0.0
RAM 74180 74180 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634473 634473 0 0.0
RAM 74180 74180 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634165 634165 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653873 653873 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653873 653873 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609469 609469 0 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629329 629329 0 0.0
RAM 71396 71396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629329 629329 0 0.0
RAM 71396 71396 0 0.0
efr32 lock-app BRD4187C FLASH 924856 924856 0 0.0
RAM 159708 159708 0 0.0
BRD4338a FLASH 741352 741344 -8 -0.0
RAM 231008 231008 0 0.0
window-app BRD4187C FLASH 1018140 1018140 0 0.0
RAM 128052 128052 0 0.0
esp32 all-clusters-app c3devkit DRAM 94248 94248 0 0.0
FLASH 1538720 1538720 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115192 115192 0 0.0
FLASH 1549066 1549066 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781027 2781045 18 0.0
RAM 129520 129680 160 0.1
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6087650 6087668 18 0.0
RAM 522912 523072 160 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5418306 5418324 18 0.0
RAM 241200 241360 160 0.1
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751768 4751786 18 0.0
RAM 218384 218544 160 0.1
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13162192 13162202 10 0.0
RAM 584562 584562 0 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11720768 11720800 32 0.0
RAM 635480 635480 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11377275 11377285 10 0.0
RAM 584218 584218 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575400 4575420 20 0.0
RAM 205048 205208 160 0.1
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692369 5692385 16 0.0
RAM 228488 228648 160 0.1
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801344 4801364 20 0.0
RAM 204472 204632 160 0.1
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430768 4430788 20 0.0
RAM 198192 198352 160 0.1
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569582 4569602 20 0.0
RAM 202760 202920 160 0.1
shell debug unknown 4216 4216 0 0.0
FLASH 3111085 3111101 16 0.0
RAM 159280 159440 160 0.1
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319520 4319552 32 0.0
RAM 242888 243064 176 0.1
tv-app debug unknown 5624 5624 0 0.0
FLASH 6031701 6031733 32 0.0
RAM 596416 596576 160 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11368029 11368045 16 0.0
RAM 675936 675936 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914492 914492 0 0.0
RAM 142359 142359 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885276 885276 0 0.0
RAM 140498 140498 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847912 847912 0 0.0
RAM 141261 141261 0 0.0
nxp contact k32w0+release FLASH 582248 582248 0 0.0
RAM 70952 70952 0 0.0
k32w1+release FLASH 597088 597088 0 0.0
RAM 63176 63176 0 0.0
mcxw71+release FLASH 596848 596848 0 0.0
RAM 63176 63176 0 0.0
light k32w0+release FLASH 618764 618764 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 683080 683080 0 0.0
RAM 48808 48808 0 0.0
mcxw71+release FLASH 683080 683080 0 0.0
RAM 48808 48808 0 0.0
lock k32w1+release FLASH 705448 705448 0 0.0
RAM 67316 67316 0 0.0
mcxw71+release FLASH 705456 705456 0 0.0
RAM 67316 67316 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646340 1646340 0 0.0
RAM 211400 211400 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552388 1552388 0 0.0
RAM 208200 208200 0 0.0
light cy8ckit_062s2_43012 FLASH 1467860 1467860 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464932 1464932 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660560 660560 0 0.0
RAM 105396 105396 0 0.0
lock-app qpg6105+debug FLASH 618580 618580 0 0.0
RAM 99864 99864 0 0.0
stm32 light STM32WB5MM-DK FLASH 481864 481864 0 0.0
RAM 144844 144844 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620998 620998 0 0.0
RAM 50648 50648 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688212 688212 0 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 781204 781204 0 0.0
RAM 110440 110440 0 0.0
bridge-app tlsr9258a FLASH 681098 681098 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620762 620762 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708716 708716 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625716 625716 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811476 811476 0 0.0
RAM 99100 99100 0 0.0
lock-app-dfu tlsr9528a FLASH 656668 656668 0 0.0
RAM 66660 66660 0 0.0
ota-requestor-app tlsr9258a FLASH 697076 697076 0 0.0
RAM 90896 90896 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634408 634408 0 0.0
RAM 55476 55476 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611598 611598 0 0.0
RAM 52720 52720 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627912 627912 0 0.0
RAM 52320 52320 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653730 653730 0 0.0
RAM 56268 56268 0 0.0
thermostat tlsr9518adk80d FLASH 638330 638330 0 0.0
RAM 53112 53112 0 0.0
window-covering tlsr9118bdk40d FLASH 524456 524456 0 0.0
RAM 97444 97444 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1726772 1726772 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18327770 18327850 80 0.0
RAM 7969632 7969452 -180 -0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

PR #34764: Size comparison from 9524ac9 to e17f0f2

Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 9524ac9 e17f0f2 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349682 1349986 304 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647742 647742 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825228 825228 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053858 1054154 296 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974998 974998 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829532 829532 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814872 814872 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761436 761436 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745664 745664 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617154 617202 48 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657258 657258 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678517 678517 0 0.0
RAM 78668 78668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698361 698361 0 0.0
RAM 81300 81300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698361 698361 0 0.0
RAM 81300 81300 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655297 655297 0 0.0
RAM 73736 73736 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614845 614845 0 0.0
RAM 71628 71628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634473 634473 0 0.0
RAM 74180 74180 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634473 634473 0 0.0
RAM 74180 74180 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634165 634165 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653873 653873 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653873 653873 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609469 609477 8 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629329 629337 8 0.0
RAM 71396 71396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629329 629337 8 0.0
RAM 71396 71396 0 0.0
efr32 lock-app BRD4187C FLASH 924856 925216 360 0.0
RAM 159708 159708 0 0.0
BRD4338a FLASH 741352 741376 24 0.0
RAM 231008 231008 0 0.0
window-app BRD4187C FLASH 1018140 1018172 32 0.0
RAM 128052 128052 0 0.0
esp32 all-clusters-app c3devkit DRAM 94248 94248 0 0.0
FLASH 1538720 1538732 12 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115192 115192 0 0.0
FLASH 1549066 1549078 12 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781027 2781107 80 0.0
RAM 129520 129680 160 0.1
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6087650 6087548 -102 -0.0
RAM 522912 523072 160 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5418306 5418298 -8 -0.0
RAM 241200 241360 160 0.1
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751768 4751738 -30 -0.0
RAM 218384 218544 160 0.1
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13162192 13161554 -638 -0.0
RAM 584562 584562 0 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11720768 11720208 -560 -0.0
RAM 635480 635480 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11377275 11377149 -126 -0.0
RAM 584218 584218 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575400 4575372 -28 -0.0
RAM 205048 205208 160 0.1
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692369 5693745 1376 0.0
RAM 228488 228648 160 0.1
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801344 4801316 -28 -0.0
RAM 204472 204632 160 0.1
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430768 4430698 -70 -0.0
RAM 198192 198352 160 0.1
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569582 4569464 -118 -0.0
RAM 202760 202920 160 0.1
shell debug unknown 4216 4216 0 0.0
FLASH 3111085 3111037 -48 -0.0
RAM 159280 159440 160 0.1
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319520 4319728 208 0.0
RAM 242888 243064 176 0.1
tv-app debug unknown 5624 5624 0 0.0
FLASH 6031701 6031605 -96 -0.0
RAM 596416 596576 160 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11368029 11367405 -624 -0.0
RAM 675936 675936 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914492 914504 12 0.0
RAM 142359 142359 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885276 885280 4 0.0
RAM 140498 140498 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847912 847924 12 0.0
RAM 141261 141261 0 0.0
nxp contact k32w0+release FLASH 582248 582248 0 0.0
RAM 70952 70952 0 0.0
k32w1+release FLASH 597088 597136 48 0.0
RAM 63176 63184 8 0.0
mcxw71+release FLASH 596848 596896 48 0.0
RAM 63176 63184 8 0.0
light k32w0+release FLASH 618764 618764 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 683080 683112 32 0.0
RAM 48808 48816 8 0.0
mcxw71+release FLASH 683080 683128 48 0.0
RAM 48808 48816 8 0.0
lock k32w1+release FLASH 705448 705480 32 0.0
RAM 67316 67324 8 0.0
mcxw71+release FLASH 705456 705504 48 0.0
RAM 67316 67324 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646340 1646388 48 0.0
RAM 211400 211400 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552388 1552436 48 0.0
RAM 208200 208200 0 0.0
light cy8ckit_062s2_43012 FLASH 1467860 1467860 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464932 1464932 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660560 660560 0 0.0
RAM 105396 105396 0 0.0
lock-app qpg6105+debug FLASH 618580 618580 0 0.0
RAM 99864 99864 0 0.0
stm32 light STM32WB5MM-DK FLASH 481864 481864 0 0.0
RAM 144844 144844 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620998 620998 0 0.0
RAM 50648 50648 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688212 688222 10 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 781204 781214 10 0.0
RAM 110440 110440 0 0.0
bridge-app tlsr9258a FLASH 681098 681098 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620762 620762 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708716 708716 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625716 625716 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811476 811724 248 0.0
RAM 99100 99100 0 0.0
lock-app-dfu tlsr9528a FLASH 656668 656668 0 0.0
RAM 66660 66660 0 0.0
ota-requestor-app tlsr9258a FLASH 697076 697076 0 0.0
RAM 90896 90896 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634408 634408 0 0.0
RAM 55476 55476 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611598 611598 0 0.0
RAM 52720 52720 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627912 627912 0 0.0
RAM 52320 52320 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653730 653730 0 0.0
RAM 56268 56268 0 0.0
thermostat tlsr9518adk80d FLASH 638330 638340 10 0.0
RAM 53112 53112 0 0.0
window-covering tlsr9118bdk40d FLASH 524456 524456 0 0.0
RAM 97444 97444 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1726772 1726716 -56 -0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18327770 18327278 -492 -0.0
RAM 7969632 7969332 -300 -0.0

@woody-apple woody-apple dismissed their stale review October 23, 2024 16:23

No longer change requested

@mergify mergify bot added the conflict label Oct 23, 2024
crlonxp and others added 17 commits October 24, 2024 11:51
@crlonxp
* Fix the dependency error
a1190e1 
* Change the default setting of WiFiPAF as enabled if running on Linux system
* Change to use C++ casting
* Move the paf cancel function from desctructor to shutdown

Signed-off-by: Lo,Chin-Ran <[email protected]>
@restyled-commits @crlonxp
Restyled by clang-format
69db993
@restyled-commits @crlonxp
Restyled by gn
aa1b652
@crlonxp
* Add the missing files
fb288b1 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@restyled-commits @crlonxp
Restyled by clang-format
4be067d
@restyled-commits @crlonxp
Restyled by gn
f4f8fa8
@crlonxp
* Add missing wpa_supplicant mutex lock
5b1ef6e 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Not failed to run immediately if wpa_supplicant is not ready
ec304d9 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
* Fix the error found by the building script
e97d26d 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Change by followign the review's comment
8321b11 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@restyled-commits @crlonxp
Restyled by clang-format
3756aed
@restyled-commits @crlonxp
Restyled by gn
6c08113
@crlonxp
Disable WiFiPAF by default
5bcb86f 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Separate the dbus parameters to have their own type, instead of using…
3154aed 
… the string

Signed-off-by: Lo,Chin-Ran <[email protected]>
@restyled-commits @crlonxp
Restyled by clang-format
bfc832d
@crlonxp
Change the dbus calling method by following the new defined api of wp…
33046d4 
…a_supplicant

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Fix a coredump if chip_device_config_enable_wifipaf is set, but --wif…
beef6d0 
…ipaf is not selected

Signed-off-by: Lo,Chin-Ran <[email protected]>
@mergify mergify bot removed the conflict label Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

PR #34764: Size comparison from 75d7e6b to a7a761a

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 75d7e6b a7a761a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350048 1350048 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647684 647684 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825248 825248 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1054238 1054238 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 975022 975022 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829548 829548 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814856 814856 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761444 761444 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745688 745688 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617226 617226 0 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657194 657194 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678629 678629 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698473 698473 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698473 698473 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655409 655409 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615045 615045 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634673 634673 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634673 634673 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634317 634317 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654033 654033 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654033 654033 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609693 609693 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629553 629553 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629553 629553 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 925644 925644 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 742216 742216 0 0.0
RAM 232580 232580 0 0.0
window-app BRD4187C FLASH 1018568 1018568 0 0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1540020 1540020 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1550198 1550198 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781357 2781521 164 0.0
RAM 129520 129680 160 0.1
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6092442 6092606 164 0.0
RAM 523840 524000 160 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5423026 5423190 164 0.0
RAM 242416 242576 160 0.1
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751606 4751770 164 0.0
RAM 218384 218544 160 0.1
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13096042 13096116 74 0.0
RAM 584402 584402 0 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11199624 11199656 32 0.0
RAM 635344 635344 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11355025 11355099 74 0.0
RAM 584890 584890 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4578190 4578324 134 0.0
RAM 205336 205496 160 0.1
fabric-sync debug unknown 4816 4816 0 0.0
FLASH 5290421 5290613 192 0.0
RAM 465416 465576 160 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5693777 5693905 128 0.0
RAM 228488 228648 160 0.1
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801184 4801318 134 0.0
RAM 204472 204632 160 0.1
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430454 4430588 134 0.0
RAM 198192 198352 160 0.1
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569226 4569360 134 0.0
RAM 202760 202920 160 0.1
shell debug unknown 4216 4216 0 0.0
FLASH 3115981 3116141 160 0.0
RAM 160368 160528 160 0.1
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4163480 4163624 144 0.0
RAM 242896 243072 176 0.1
tv-app debug unknown 5624 5624 0 0.0
FLASH 6032501 6032693 192 0.0
RAM 596256 596416 160 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11300541 11300621 80 0.0
RAM 694536 694536 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915564 915564 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886048 886048 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848972 848972 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582424 582424 0 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596912 596912 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 619044 619044 0 0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 683144 683144 0 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746696 746696 0 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647652 1647652 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553724 1553724 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1467988 1467988 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464964 1464964 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660544 660544 0 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618620 618620 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481920 481920 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 681138 681138 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620788 620788 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708768 708768 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625738 625738 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811748 811748 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1729948 1729948 0 0.0
RAM 90108 90108 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18237374 18237462 88 0.0
RAM 7946324 7946144 -180 -0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

Assignees
No one assigned
Labels
app controller examples lib linux platform review - pending tools transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crlonxp @andy31415 @woody-apple @restyled-commits