-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Service Area with name changes since 0.7 #34711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd some of their enums.
… and their enum names.
…rrentLocation attributes.
Review changes with SemanticDiff. Analyzed 8 of 55 files. File Information
|
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 1, 2024 16:20
PR #34711: Size comparison from 923619a to 86c38ed Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
PR #34711: Size comparison from 923619a to a611a5b Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34711: Size comparison from d0d9127 to 56d0184 Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
PR #34711: Size comparison from d0d9127 to b3abfbd Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
plauric
approved these changes
Aug 2, 2024
bzbarsky-apple
approved these changes
Aug 2, 2024
PR #34711: Size comparison from bbef51a to 4f61bf3 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34667
This PR implements the various name changes that have taken place in the Service Area spec since the 0.7 ballot. Changes where made to the XML, the generated code, the SDK server Impl and rvc-app example.
The following name changes where made.
LocationInfoStruct
toAreaInfoStruct
LocationStruct
toAreaStruct
and theLocationID
andLocationDesc
fields toAreaID
andAreaDesc
.ProgressStruct
'sLocationID
field toAreaID
SelectLocationsStatus
toSelectAreasStatus
and theUnsupportedLocation
andDuplicatedLocations
enums toUnsupportedArea
andDuplicatedAreas
.SkipCurrentLocationStatus
toSkipAreaStatus
and itsInvalidLocationList
enum toInvalidAreaList
SupportedLocations
toSupportedAreas
SelectedLocations
toSelectedAreas
CurrentLocation
toCurrentArea
SelectLocations
toSelectAreas
SelectLocationsResponse
toSelectAreasResponse
SkipLocation
toSkipArea
SkipLocationResponse
toSkipAreaResponse