-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fabric sync example to accept KeepActive Command #34636
Merged
tehampson
merged 14 commits into
project-chip:master
from
tehampson:handle-keep-active-command-in-fabric-bridge-app
Aug 8, 2024
Merged
Allow fabric sync example to accept KeepActive Command #34636
tehampson
merged 14 commits into
project-chip:master
from
tehampson:handle-keep-active-command-in-fabric-bridge-app
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
PR #34636: Size comparison from cc55c2a to 721e631 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34636: Size comparison from d47c423 to dd94a5e Full report (19 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
tehampson
changed the title
Add CommandHandler to fabric-bridge
Allow fabric sync example to accept KeepActive Command
Aug 7, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro and
cliffamzn
August 7, 2024 21:26
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 7, 2024 21:26
PR #34636: Size comparison from d47c423 to 2d88a17 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 8, 2024
tehampson
commented
Aug 8, 2024
PR #34636: Size comparison from 514b9eb to bd12b00 Increases above 0.2%:
Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
andy31415
reviewed
Aug 8, 2024
andy31415
reviewed
Aug 8, 2024
andy31415
approved these changes
Aug 8, 2024
andy31415
reviewed
Aug 8, 2024
PR #34636: Size comparison from 514b9eb to 19b7ba2 Increases above 0.2%:
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following three things:
KeepActive
Command on dynamic bridged node endpointKeepActive
command to fabric-adminStayActiveResponse
response when received to back to fabric-bridge so that is can Log and ActiveChanged event.In a follow up PR we will work on converting a
KeepActive
command received in fabric-admin in item #2 toStayActiveRequest
when the ICD device is currently active and call the plumbing from item #3