Updated WHM XML to align to spec PR 10028 #34560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta types and command).
|
Review changes with SemanticDiff. Analyzed 11 of 46 files. Overall, the semantic diff is 9% smaller than the GitHub diff. File Information
|
…align-to-spec-PR-10028
…align-to-spec-PR-10028
…iling with unhelpful error message.
…eatSourceBitmap. Added boostInfo structure into command. Now All-clusters-app compiles again. Some brief reformatting.
…Added to the tests.yaml which was missing.
|
PR #34560: Size comparison from d0d9127 to 43a43d3 Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #34560: Size comparison from d0d9127 to fbbeadb Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
|
PR #34560: Size comparison from d0d9127 to 5e5488b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34560: Size comparison from d0d9127 to 9708e5d Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq and
axelnxp
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34560: Size comparison from d0d9127 to e1966f4 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34560: Size comparison from d0d9127 to 5e5b22c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34560: Size comparison from d0d9127 to 895d1e7 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 6, 2024
hasty
approved these changes
Aug 7, 2024
github-actions
bot
added
the
matter-1.4-te2-script-change
jamesharrow
commented
Aug 8, 2024
|
PR #34560: Size comparison from ea01e21 to f1a9f51 Full report (3 builds for cc32xx, stm32)
|
|
PR #34560: Size comparison from ea01e21 to 28f3559 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@jamesharrow - Hi James, just a quick note for you. Since the new python test executable code got merged in master yesterday. You would want to remove the exclusion of the tests "TC_EWATERHTR*.py" from the script "src/python_testing/execute_python_test.py" in order to have them executed. |
|
PR #34560: Size comparison from fd1421c to 8d4dc03 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Yep - thanks - already removed it! |
andy31415
approved these changes
Aug 8, 2024
jamesharrow
deleted the
Update-WHM-XML-to-add-events-and-align-to-spec-PR-10028
branch
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
* Updated XML to align to spec PR 10028, (Adds Events and simplifies data types and command). * Bumped cluster revision to 2 * Added missing Descriptions to the Events to avoid ZAP regen_all.py failing with unhelpful error message. * Updated autogen'd files from regen_all.py * Renamed WaterHeaterTypeBitmap/WaterHeaterDemandBitmap -> WaterHeaterHeatSourceBitmap. Added boostInfo structure into command. Now All-clusters-app compiles again. Some brief reformatting. * Added missing new Java files. * Updated test scripts to work with new types and boostInfo structure. Added to the tests.yaml which was missing. * Corrected test-runner command linewrap issue * Removed featureSet command flag in test runner which is not in All-cluster-app. * Added missing apiMaturity="provisional" to WaterHeaterHeatSourceBitmap. * Update .github/workflows/tests.yaml * Re-aligned the XML after some late changes to the constraints in the spec. --------- Co-authored-by: Hasty Granbery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the WHM XML (and autogenerated code) to align to the spec PR 10028
This also includes regen_all.py and necessary changes to keep all_clusters_app compiling and fixes up the test scripts so that they run and pass again.
It does not add support for Events etc - this will be added in another PR.