Add a way to force reporting when setting attr value in ember store. #34521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a QuieterReportingAttribute to track whether reporting is needed, we can end up in a situation where we set a value that we have not reported yet, and then an edge happens that requires reporting to be triggered, without the relevant value changing. In that situation the QuieterReportingAttribute remembers the last-reported value (not just the last-set one), and will return AttributeDirtyState::kMustReport. What was missing was a way to tell the ember data store "go ahead and report this, even though we are not in fact changing the value". We want that, in this case, since the ember data store just knows the last-set value, not the last-reported one.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34521: Size comparison from ba949bf to 64423be Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 26, 2024
jmartinez-silabs
approved these changes
Jul 30, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…roject-chip#34521) When using a QuieterReportingAttribute to track whether reporting is needed, we can end up in a situation where we set a value that we have not reported yet, and then an edge happens that requires reporting to be triggered, without the relevant value changing. In that situation the QuieterReportingAttribute remembers the last-reported value (not just the last-set one), and will return AttributeDirtyState::kMustReport. What was missing was a way to tell the ember data store "go ahead and report this, even though we are not in fact changing the value". We want that, in this case, since the ember data store just knows the last-set value, not the last-reported one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a QuieterReportingAttribute to track whether reporting is needed, we can end up in a situation where we set a value that we have not reported yet, and then an edge happens that requires reporting to be triggered, without the relevant value changing. In that situation the QuieterReportingAttribute remembers the last-reported value (not just the last-set one), and will return AttributeDirtyState::kMustReport.
What was missing was a way to tell the ember data store "go ahead and report this, even though we are not in fact changing the value". We want that, in this case, since the ember data store just knows the last-set value, not the last-reported one.