Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in MTRDevice comment. #34463

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix typo in MTRDevice comment. #34463

merged 1 commit into from
Jul 24, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

PR #34463: Size comparison from 985a9b0 to be8c077

Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 985a9b0 be8c077 change % change
bl602 lighting-app bl602 FLASH 1271952 1271952 0 0.0
RAM 95384 95384 0 0.0
bl602+mfd FLASH 1286210 1286210 0 0.0
RAM 95528 95528 0 0.0
bl602+rpc FLASH 1310920 1310920 0 0.0
RAM 103808 103808 0 0.0
bl702 lighting-app bl702 FLASH 1092846 1092846 0 0.0
RAM 15245 15245 0 0.0
bl702+mfd FLASH 1103540 1103540 0 0.0
RAM 15397 15397 0 0.0
bl702+rpc FLASH 1182912 1182912 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 876146 876146 0 0.0
RAM 27348 27348 0 0.0
bl706-wifi FLASH 1128328 1128328 0 0.0
RAM 14681 14681 0 0.0
bl702l lighting-app bl702l FLASH 1079744 1079744 0 0.0
RAM 21800 21800 0 0.0
bl702l+mfd FLASH 1091006 1091006 0 0.0
RAM 21960 21960 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798868 798868 0 0.0
RAM 109236 109236 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816620 816620 0 0.0
RAM 117020 117020 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808468 808468 0 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761084 761084 0 0.0
RAM 105408 105408 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746868 746868 0 0.0
RAM 105632 105632 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606646 606646 0 0.0
RAM 204564 204564 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651994 651994 0 0.0
RAM 204836 204836 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 668009 668009 0 0.0
RAM 77700 77700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687861 687861 0 0.0
RAM 80340 80340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687861 687861 0 0.0
RAM 80340 80340 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644805 644805 0 0.0
RAM 72768 72768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609561 609561 0 0.0
RAM 70884 70884 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629189 629189 0 0.0
RAM 73428 73428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629189 629189 0 0.0
RAM 73428 73428 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625257 625257 0 0.0
RAM 73900 73900 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644965 644965 0 0.0
RAM 76444 76444 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644965 644965 0 0.0
RAM 76444 76444 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593629 593629 0 0.0
RAM 67852 67852 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613481 613481 0 0.0
RAM 70492 70492 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613481 613481 0 0.0
RAM 70492 70492 0 0.0
efr32 lighting-app BRD4187C FLASH 926120 926120 0 0.0
RAM 134528 134528 0 0.0
lock-app BRD4338a FLASH 734508 734500 -8 -0.0
RAM 208004 208004 0 0.0
window-app BRD4187C FLASH 1014572 1014572 0 0.0
RAM 126648 126648 0 0.0
esp32 all-clusters-app c3devkit DRAM 90924 90924 0 0.0
FLASH 1471174 1471174 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117404 0 0.0
FLASH 1540279 1540279 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2706933 2706933 0 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5835410 5835410 0 0.0
RAM 494784 494784 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5295110 5295110 0 0.0
RAM 235728 235728 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4694432 4694432 0 0.0
RAM 212992 212992 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12297022 12297022 0 0.0
RAM 548882 548882 0 0.0
chip-tool-ipv6only arm64 unknown 20168 20168 0 0.0
FLASH 11003052 11003052 0 0.0
RAM 598528 598528 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11314955 11314955 0 0.0
RAM 545722 545722 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4448666 4448666 0 0.0
RAM 199024 199024 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5618513 5618513 0 0.0
RAM 224272 224272 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4752884 4752884 0 0.0
RAM 200704 200704 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4397376 4397376 0 0.0
RAM 194880 194880 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4535158 4535158 0 0.0
RAM 199416 199416 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2979645 2979645 0 0.0
RAM 153736 153736 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4256916 4256916 0 0.0
RAM 236336 236336 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5893615 5893615 0 0.0
RAM 342112 342112 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10431997 10431997 0 0.0
RAM 403080 403080 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503276 1503276 0 0.0
RAM 226720 226720 0 0.0
nxp contact k32w0+release FLASH 576100 576100 0 0.0
RAM 70104 70104 0 0.0
k32w1+release FLASH 591664 591664 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 610400 610400 0 0.0
RAM 69564 69564 0 0.0
k32w1+release FLASH 675184 675184 0 0.0
RAM 82872 82872 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1611652 1611652 0 0.0
RAM 209728 209728 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1531988 1531988 0 0.0
RAM 206544 206544 0 0.0
light cy8ckit_062s2_43012 FLASH 1458812 1458812 0 0.0
RAM 199808 199808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459468 1459468 0 0.0
RAM 224328 224328 0 0.0
qpg lighting-app qpg6105+debug FLASH 651724 651724 0 0.0
RAM 104636 104636 0 0.0
lock-app qpg6105+debug FLASH 612112 612112 0 0.0
RAM 99320 99320 0 0.0
stm32 light STM32WB5MM-DK FLASH 474064 474064 0 0.0
RAM 144260 144260 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 633084 633084 0 0.0
RAM 50576 50576 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658936 658936 0 0.0
RAM 148480 148480 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779162 779162 0 0.0
RAM 113260 113260 0 0.0
bridge-app tlsr9258a FLASH 676004 676004 0 0.0
RAM 95344 95344 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634668 634668 0 0.0
RAM 50620 50620 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720540 720540 0 0.0
RAM 77196 77196 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 614038 614038 0 0.0
RAM 144684 144684 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801842 801842 0 0.0
RAM 103088 103088 0 0.0
lock-app-dfu tlsr9528a FLASH 666496 666496 0 0.0
RAM 69900 69900 0 0.0
ota-requestor-app tlsr9258a FLASH 695366 695366 0 0.0
RAM 95068 95068 0 0.0
pump-app tlsr9518adk80d FLASH 616932 616932 0 0.0
RAM 57000 57000 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607342 607342 0 0.0
RAM 56800 56800 0 0.0
shell tlsr9518adk80d FLASH 466520 466520 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641286 641286 0 0.0
RAM 52248 52248 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651164 651164 0 0.0
RAM 60436 60436 0 0.0
thermostat tlsr9518adk80d FLASH 626228 626228 0 0.0
RAM 57124 57124 0 0.0
window-covering tlsr9118bdk40d FLASH 519434 519434 0 0.0
RAM 97856 97856 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1641212 1641212 0 0.0
RAM 48708 48708 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16324654 16324654 0 0.0
RAM 7168528 7168528 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@mergify mergify bot merged commit 8ad0bdf into project-chip:master Jul 24, 2024
69 checks passed
@bzbarsky-apple bzbarsky-apple deleted the fix-typo branch July 25, 2024 18:06
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@bzbarsky-apple @j-ororke
Fix typo in MTRDevice comment. (project-chip#34463)
84ec672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiel-apple kiel-apple kiel-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @kiel-apple