Add the ability for EventLoopHandlers to participate in a Select-based event loop #34433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
…h=false Note: This is for unit testing / development purposes only.
ksperling-apple
force-pushed
the
eventloophandler
branch
from
f1b152b to
d3f70f6
Compare
|
PR #34433: Size comparison from 8e32ce7 to d3f70f6 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
ksperling-apple
force-pushed
the
eventloophandler
branch
from
d3f70f6 to
c76229d
Compare
|
PR #34433: Size comparison from 8306353 to c76229d Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 31, 2024
andy31415
previously requested changes
Jul 31, 2024
There was a problem hiding this comment.
Please add documentation to the PR summary for me to understand what this PR is about before reading it. the title of Add the ability for EventLoopHandlers to participate ... does not explain what event loop handlers are, why we have them.
Also overall there should be better documentation in the files and eventloophandler seems stand-alone and should be a separate header.
andy31415
reviewed
Jul 31, 2024
andy31415
reviewed
Jul 31, 2024
andy31415
reviewed
Jul 31, 2024
andy31415
reviewed
Jul 31, 2024
andy31415
reviewed
Jul 31, 2024
(Sorry accidentally ended up editing the comment when I meant to hit quote reply) As far as understanding the context goes, in my opinion it would have been easier to see what the purpose of an EventLoopHandler is by seeing an example of how one is used. This is why I originally included this code in #33968, but broke it out into a separate PR based on your request. I'm adding more documentation as requested and investigating the test failure. |
The fake PlatformManagerImpl doesn't drive the SystemLayer event loop.
|
PR #34433: Size comparison from 10531e1 to 4100ebc Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Aug 21, 2024
andy31415
dismissed
their stale review
Dismissing changes requested: summary was updated and has several checkmarks. This should not be blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventLoopHandlers can be registered with aLayerSocketsLoopinstance to enable participation of those handlers in the processing cycle of the event loop. This makes it possible to implement adapters that allow components utilizing a third-party event loop API (e.g. ubus) to participate in the Matter event loop, instead of having to run an entirely separate event loop on another thread.This was split out of #33968.