-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chip-build
image to 65
#34373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
July 17, 2024 13:45
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
July 17, 2024 13:45
Damian-Nordic
approved these changes
Jul 17, 2024
andy31415
force-pushed
the
use_chip_build_65
branch
from
July 17, 2024 13:52
75147c6
to
7cc2ddb
Compare
PR #34373: Size comparison from a30dd12 to 7cc2ddb Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
andy31415
force-pushed
the
use_chip_build_65
branch
from
July 17, 2024 14:09
7cc2ddb
to
0136fac
Compare
arkq
approved these changes
Jul 17, 2024
PR #34373: Size comparison from a30dd12 to 17116da Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
… some pybind dependencies
PR #34373: Size comparison from a30dd12 to e1379d6 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Jul 17, 2024
PR #34373: Size comparison from a30dd12 to e81303a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…aReportingOnToggle does not properly fail with latest python, this needs debugging
PR #34373: Size comparison from a30dd12 to b03e58e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Mass update from chip-build:54 to chip-build:65. This is for chip-build image only. * Noop change to force caches to be different across environments * Use lsbrelease for the hash key * Do not update paths that build python bits just yet: it seems we have some pybind dependencies * Update one more python to not use the latest as it needs package updates * Remove one more build update ... apparently TestPurposefulFailureExtraReportingOnToggle does not properly fail with latest python, this needs debugging --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only updates chip-build and not all the other images.
Expect to gradually update images one by one and fix anything that breaks.
#34025 attempts a mass complete update, however it seems to show there is still individual work to do.
Changes
Several updates not done:
TestPurposefulFailureExtraReportingOnToggle
does not fail anymore on latest python, needs debugging why (since this is a intentional failure case, we do not log sufficient data on success to debug)