Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Changes to support product-appearance attribute in ESP32. #34363

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[ESP32] Changes to support product-appearance attribute in ESP32. #34363

merged 3 commits into from
Jul 24, 2024

Conversation

shripad621git
Copy link
Contributor

Problem

  • The implemenation for DeviceInstanceInfoProvider for product-apperance attribute of basic information cluster was missing.
  • Also, support for the attribute was missing in factory_partition generation script.

Change Overview

  • Added the support for product-appearance attribute in script.
  • Added a DeviceInstanceInfoProvider implementation for the attribute.

Testing

  • Tested the script by generating a factory_partition with these attributes.
  • Tested the DeviceInstanceInfo provider implementation by flashing factory partition with esp32 lighting app and reading the product-appearance attribute.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34363: Size comparison from 0840ca6 to 98d8992

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 0840ca6 98d8992 change % change
bl602 lighting-app bl602 FLASH 1271504 1271504 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1286018 1286018 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310720 1310720 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092614 1092614 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103308 1103308 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182424 1182424 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875744 875744 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1128170 1128170 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079500 1079500 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090762 1090762 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798604 798604 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816572 816572 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808260 808260 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760940 760940 0 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746652 746652 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606482 606482 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651806 651806 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667713 667713 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644509 644509 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609329 609329 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625057 625057 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593429 593429 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924660 -8 -0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733908 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012700 1012692 -8 -0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90860 90876 16 0.0
FLASH 1470728 1470802 74 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117340 117356 16 0.0
FLASH 1539579 1539663 84 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2531376 2531376 0 0.0
RAM 125112 125112 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5592478 5592478 0 0.0
RAM 493240 493240 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5065568 5065568 0 0.0
RAM 235704 235704 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4479776 4479776 0 0.0
RAM 212832 212832 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11797879 11797879 0 0.0
RAM 547618 547618 0 0.0
chip-tool-ipv6only arm64 unknown 20128 20128 0 0.0
FLASH 10908108 10908108 0 0.0
RAM 596616 596616 0 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10877607 10877607 0 0.0
RAM 544394 544394 0 0.0
fabric-bridge-app debug unknown 4544 4544 0 0.0
FLASH 4247344 4247344 0 0.0
RAM 198872 198872 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5384162 5384162 0 0.0
RAM 224136 224136 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4546128 4546128 0 0.0
RAM 200456 200456 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4199216 4199216 0 0.0
RAM 194544 194544 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4324544 4324544 0 0.0
RAM 199168 199168 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2805869 2805869 0 0.0
RAM 153008 153008 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4169772 4169772 0 0.0
RAM 235840 235840 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5627776 5627776 0 0.0
RAM 342120 342120 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9967950 9967950 0 0.0
RAM 402936 402936 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1502972 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882696 882696 0 0.0
RAM 142229 142229 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953128 953128 0 0.0
RAM 140657 140657 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828172 828172 0 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 576164 576164 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591568 591568 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610408 610408 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675192 675192 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615620 1615620 0 0.0
RAM 209692 209692 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536508 1536508 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463108 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463868 1463868 0 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651460 651460 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611992 611992 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473784 0 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632984 632984 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658842 658842 0 0.0
RAM 148408 148408 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779144 779144 0 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675976 675976 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634568 634568 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720428 720428 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613948 613948 0 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801730 801730 0 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666384 666384 0 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695308 695308 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616842 616842 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607226 607226 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466356 466356 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641186 641186 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651052 651052 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626116 626116 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519342 519342 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1639396 1639396 0 0.0
RAM 48548 48548 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16293278 16293278 0 0.0
RAM 7156300 7156300 0 0.0

@shripad621git shripad621git force-pushed the script/product_appearance branch from 98d8992 to 7f513d9 Compare July 17, 2024 09:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34363: Size comparison from df8c9da to 7f513d9

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section df8c9da 7f513d9 change % change
bl602 lighting-app bl602 FLASH 1271504 1271504 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1286018 1286018 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310720 1310720 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092614 1092614 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103308 1103308 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182424 1182424 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875744 875744 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1128170 1128170 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079500 1079500 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090762 1090762 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798604 798604 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816572 816572 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808260 808260 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760940 760940 0 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746652 746652 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606482 606482 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651806 651806 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667713 667713 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644509 644509 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609329 609329 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625057 625057 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593429 593429 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924660 -8 -0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733908 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012700 1012692 -8 -0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90860 90876 16 0.0
FLASH 1470728 1470802 74 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117340 117356 16 0.0
FLASH 1539579 1539663 84 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2531376 2531376 0 0.0
RAM 125112 125112 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5592478 5592478 0 0.0
RAM 493240 493240 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5065568 5065568 0 0.0
RAM 235704 235704 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4479776 4479776 0 0.0
RAM 212832 212832 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11797879 11797879 0 0.0
RAM 547618 547618 0 0.0
chip-tool-ipv6only arm64 unknown 20128 20128 0 0.0
FLASH 10908108 10908108 0 0.0
RAM 596616 596616 0 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10877607 10877607 0 0.0
RAM 544394 544394 0 0.0
fabric-bridge-app debug unknown 4544 4544 0 0.0
FLASH 4247344 4247344 0 0.0
RAM 198872 198872 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5384162 5384162 0 0.0
RAM 224136 224136 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4546128 4546128 0 0.0
RAM 200456 200456 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4199216 4199216 0 0.0
RAM 194544 194544 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4324544 4324544 0 0.0
RAM 199168 199168 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2805869 2805869 0 0.0
RAM 153008 153008 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4169772 4169772 0 0.0
RAM 235840 235840 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5627776 5627776 0 0.0
RAM 342120 342120 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9967950 9967950 0 0.0
RAM 402936 402936 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1502972 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882696 882696 0 0.0
RAM 142229 142229 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953128 953128 0 0.0
RAM 140657 140657 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828172 828172 0 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 576164 576164 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591568 591568 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610408 610408 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675192 675192 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615620 1615620 0 0.0
RAM 209692 209692 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536508 1536508 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463108 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463868 1463868 0 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651460 651460 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611992 611992 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473784 0 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632984 632984 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658842 658842 0 0.0
RAM 148408 148408 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779144 779144 0 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675976 675976 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634568 634568 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720428 720428 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613948 613948 0 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801730 801730 0 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666384 666384 0 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695308 695308 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616842 616842 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607226 607226 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466356 466356 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641186 641186 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651052 651052 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626116 626116 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519342 519342 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1639396 1639396 0 0.0
RAM 48548 48548 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16293278 16293278 0 0.0
RAM 7156300 7156300 0 0.0

@shripad621git shripad621git force-pushed the script/product_appearance branch from 7f513d9 to 5d0d5a4 Compare July 22, 2024 09:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

PR #34363: Size comparison from 3cb0ae9 to 5d0d5a4

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3cb0ae9 5d0d5a4 change % change
bl602 lighting-app bl602 FLASH 1272020 1272020 0 0.0
RAM 95392 95392 0 0.0
bl602+mfd FLASH 1286278 1286278 0 0.0
RAM 95536 95536 0 0.0
bl602+rpc FLASH 1310988 1310988 0 0.0
RAM 103816 103816 0 0.0
bl702 lighting-app bl702 FLASH 1092926 1092926 0 0.0
RAM 15229 15229 0 0.0
bl702+mfd FLASH 1103876 1103876 0 0.0
RAM 15381 15381 0 0.0
bl702+rpc FLASH 1182992 1182992 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 876226 876226 0 0.0
RAM 27348 27348 0 0.0
bl706-wifi FLASH 1128408 1128408 0 0.0
RAM 14681 14681 0 0.0
bl702l lighting-app bl702l FLASH 1080068 1080068 0 0.0
RAM 21800 21800 0 0.0
bl702l+mfd FLASH 1091074 1091074 0 0.0
RAM 21960 21960 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798884 798884 0 0.0
RAM 109236 109236 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816636 816636 0 0.0
RAM 117028 117028 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808492 808492 0 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761092 761092 0 0.0
RAM 105400 105400 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746876 746876 0 0.0
RAM 105632 105632 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606630 606630 0 0.0
RAM 204572 204572 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651970 651970 0 0.0
RAM 204844 204844 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 668025 668025 0 0.0
RAM 77700 77700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687877 687877 0 0.0
RAM 80340 80340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687877 687877 0 0.0
RAM 80340 80340 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644813 644813 0 0.0
RAM 72768 72768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609561 609561 0 0.0
RAM 70876 70876 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629197 629197 0 0.0
RAM 73420 73420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629197 629197 0 0.0
RAM 73420 73420 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625273 625273 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644981 644981 0 0.0
RAM 76436 76436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644981 644981 0 0.0
RAM 76436 76436 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593637 593637 0 0.0
RAM 67844 67844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70484 70484 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70484 70484 0 0.0
efr32 lighting-app BRD4187C FLASH 926112 926112 0 0.0
RAM 134532 134532 0 0.0
lock-app BRD4338a FLASH 734524 734516 -8 -0.0
RAM 208000 208000 0 0.0
window-app BRD4187C FLASH 1014604 1014604 0 0.0
RAM 126644 126644 0 0.0
esp32 all-clusters-app c3devkit DRAM 90932 90948 16 0.0
FLASH 1471314 1471388 74 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117420 16 0.0
FLASH 1540315 1540383 68 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2706913 2706913 0 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5835478 5835478 0 0.0
RAM 494688 494688 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5295130 5295130 0 0.0
RAM 235696 235696 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4694462 4694462 0 0.0
RAM 212960 212960 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12296496 12296496 0 0.0
RAM 548818 548818 0 0.0
chip-tool-ipv6only arm64 unknown 20168 20168 0 0.0
FLASH 11002556 11002556 0 0.0
RAM 598464 598464 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 1131456 1131456 0 0.0
RAM 545658 545658 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4448640 4448640 0 0.0
RAM 198992 198992 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5618529 5618529 0 0.0
RAM 224240 224240 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4752912 4752912 0 0.0
RAM 200672 200672 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4397300 4397300 0 0.0
RAM 194848 194848 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4535114 4535114 0 0.0
RAM 199384 199384 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2979645 2979645 0 0.0
RAM 153736 153736 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4256884 4256884 0 0.0
RAM 236336 236336 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5893615 5893615 0 0.0
RAM 342080 342080 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10431405 10431405 0 0.0
RAM 403080 403080 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503276 1503276 0 0.0
RAM 226728 226728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883308 883308 0 0.0
RAM 142311 142311 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953548 953548 0 0.0
RAM 140739 140739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828160 828160 0 0.0
RAM 141179 141179 0 0.0
nxp contact k32w0+release FLASH 576100 576100 0 0.0
RAM 70096 70096 0 0.0
k32w1+release FLASH 591664 591664 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 610416 610416 0 0.0
RAM 69564 69564 0 0.0
k32w1+release FLASH 675192 675192 0 0.0
RAM 82880 82880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1611636 1611636 0 0.0
RAM 209736 209736 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1531956 1531956 0 0.0
RAM 206544 206544 0 0.0
light cy8ckit_062s2_43012 FLASH 1458812 1458812 0 0.0
RAM 199808 199808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459468 1459468 0 0.0
RAM 224336 224336 0 0.0
qpg lighting-app qpg6105+debug FLASH 651740 651740 0 0.0
RAM 104644 104644 0 0.0
lock-app qpg6105+debug FLASH 612144 612144 0 0.0
RAM 99312 99312 0 0.0
stm32 light STM32WB5MM-DK FLASH 474064 474064 0 0.0
RAM 144268 144268 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 633102 633102 0 0.0
RAM 50576 50576 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 659054 659054 0 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779246 779246 0 0.0
RAM 113260 113260 0 0.0
bridge-app tlsr9258a FLASH 676078 676078 0 0.0
RAM 95352 95352 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634686 634686 0 0.0
RAM 50620 50620 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720554 720554 0 0.0
RAM 77196 77196 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 614130 614130 0 0.0
RAM 144684 144684 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801934 801934 0 0.0
RAM 103088 103088 0 0.0
lock-app-dfu tlsr9528a FLASH 666510 666510 0 0.0
RAM 69900 69900 0 0.0
ota-requestor-app tlsr9258a FLASH 695436 695436 0 0.0
RAM 95076 95076 0 0.0
pump-app tlsr9518adk80d FLASH 616942 616942 0 0.0
RAM 57000 57000 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607352 607352 0 0.0
RAM 56800 56800 0 0.0
shell tlsr9518adk80d FLASH 466520 466520 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641304 641304 0 0.0
RAM 52248 52248 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651178 651178 0 0.0
RAM 60436 60436 0 0.0
thermostat tlsr9518adk80d FLASH 626242 626242 0 0.0
RAM 57132 57132 0 0.0
window-covering tlsr9118bdk40d FLASH 519448 519448 0 0.0
RAM 97848 97848 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1641256 1641256 0 0.0
RAM 48708 48708 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16310718 16310718 0 0.0
RAM 7168520 7168520 0 0.0

@shripad621git
Changes to support product-appearance attribute on ESP32.
f9ebabd 
- Added the support for product-appearance attribute of BasicInformationCluster in factory script.
- Added DeviceInstanceInfoProvider implementation for the attribute.
@shripad621git
Addressed review comments
7084a0c
@shripad621git
Changes to support few more missing attributes
adf2bb3
@shripad621git shripad621git force-pushed the script/product_appearance branch from 5d0d5a4 to adf2bb3 Compare July 23, 2024 11:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

PR #34363: Size comparison from f6022e4 to adf2bb3

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section f6022e4 adf2bb3 change % change
bl602 lighting-app bl602 FLASH 1272020 1272020 0 0.0
RAM 95392 95392 0 0.0
bl602+mfd FLASH 1286278 1286278 0 0.0
RAM 95536 95536 0 0.0
bl602+rpc FLASH 1310988 1310988 0 0.0
RAM 103816 103816 0 0.0
bl702 lighting-app bl702 FLASH 1092926 1092926 0 0.0
RAM 15229 15229 0 0.0
bl702+mfd FLASH 1103876 1103876 0 0.0
RAM 15381 15381 0 0.0
bl702+rpc FLASH 1182992 1182992 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 876226 876226 0 0.0
RAM 27348 27348 0 0.0
bl706-wifi FLASH 1128408 1128408 0 0.0
RAM 14681 14681 0 0.0
bl702l lighting-app bl702l FLASH 1080068 1080068 0 0.0
RAM 21800 21800 0 0.0
bl702l+mfd FLASH 1091074 1091074 0 0.0
RAM 21960 21960 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798884 798884 0 0.0
RAM 109236 109236 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816636 816636 0 0.0
RAM 117028 117028 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808492 808492 0 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761092 761092 0 0.0
RAM 105400 105400 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746876 746876 0 0.0
RAM 105632 105632 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606630 606630 0 0.0
RAM 204572 204572 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651970 651970 0 0.0
RAM 204844 204844 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 668025 668025 0 0.0
RAM 77700 77700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687877 687877 0 0.0
RAM 80340 80340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687877 687877 0 0.0
RAM 80340 80340 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644813 644813 0 0.0
RAM 72768 72768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609561 609561 0 0.0
RAM 70876 70876 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629197 629197 0 0.0
RAM 73420 73420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629197 629197 0 0.0
RAM 73420 73420 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625273 625273 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644981 644981 0 0.0
RAM 76436 76436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644981 644981 0 0.0
RAM 76436 76436 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593637 593637 0 0.0
RAM 67844 67844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70484 70484 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70484 70484 0 0.0
efr32 lighting-app BRD4187C FLASH 926112 926112 0 0.0
RAM 134532 134532 0 0.0
lock-app BRD4338a FLASH 734524 734516 -8 -0.0
RAM 208000 208000 0 0.0
window-app BRD4187C FLASH 1014604 1014604 0 0.0
RAM 126644 126644 0 0.0
esp32 all-clusters-app c3devkit DRAM 90932 90956 24 0.0
FLASH 1471314 1471416 102 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117428 24 0.0
FLASH 1540315 1540411 96 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2706913 2706913 0 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5835478 5835478 0 0.0
RAM 494688 494688 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5295130 5295130 0 0.0
RAM 235696 235696 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4694462 4694462 0 0.0
RAM 212960 212960 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12296496 12296496 0 0.0
RAM 548818 548818 0 0.0
chip-tool-ipv6only arm64 unknown 20168 20168 0 0.0
FLASH 11002556 11002556 0 0.0
RAM 598464 598464 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 1131456 1131456 0 0.0
RAM 545658 545658 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4448640 4448640 0 0.0
RAM 198992 198992 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5618529 5618529 0 0.0
RAM 224240 224240 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4752912 4752912 0 0.0
RAM 200672 200672 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4397300 4397300 0 0.0
RAM 194848 194848 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4535114 4535114 0 0.0
RAM 199384 199384 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2979645 2979645 0 0.0
RAM 153736 153736 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4256884 4256884 0 0.0
RAM 236336 236336 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5893615 5893615 0 0.0
RAM 342080 342080 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10431405 10431405 0 0.0
RAM 403080 403080 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503276 1503276 0 0.0
RAM 226728 226728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883308 883308 0 0.0
RAM 142311 142311 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953548 953548 0 0.0
RAM 140739 140739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828160 828160 0 0.0
RAM 141179 141179 0 0.0
nxp contact k32w0+release FLASH 576100 576100 0 0.0
RAM 70096 70096 0 0.0
k32w1+release FLASH 591664 591664 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 610416 610416 0 0.0
RAM 69564 69564 0 0.0
k32w1+release FLASH 675192 675192 0 0.0
RAM 82880 82880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1611636 1611636 0 0.0
RAM 209736 209736 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1531956 1531956 0 0.0
RAM 206544 206544 0 0.0
light cy8ckit_062s2_43012 FLASH 1458812 1458812 0 0.0
RAM 199808 199808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459468 1459468 0 0.0
RAM 224336 224336 0 0.0
qpg lighting-app qpg6105+debug FLASH 651740 651740 0 0.0
RAM 104644 104644 0 0.0
lock-app qpg6105+debug FLASH 612144 612144 0 0.0
RAM 99312 99312 0 0.0
stm32 light STM32WB5MM-DK FLASH 474064 474064 0 0.0
RAM 144268 144268 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 633102 633102 0 0.0
RAM 50576 50576 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 659054 659054 0 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779246 779246 0 0.0
RAM 113260 113260 0 0.0
bridge-app tlsr9258a FLASH 676078 676078 0 0.0
RAM 95352 95352 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634686 634686 0 0.0
RAM 50620 50620 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720554 720554 0 0.0
RAM 77196 77196 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 614130 614130 0 0.0
RAM 144684 144684 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801934 801934 0 0.0
RAM 103088 103088 0 0.0
lock-app-dfu tlsr9528a FLASH 666510 666510 0 0.0
RAM 69900 69900 0 0.0
ota-requestor-app tlsr9258a FLASH 695436 695436 0 0.0
RAM 95076 95076 0 0.0
pump-app tlsr9518adk80d FLASH 616942 616942 0 0.0
RAM 57000 57000 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607352 607352 0 0.0
RAM 56800 56800 0 0.0
shell tlsr9518adk80d FLASH 466520 466520 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641304 641304 0 0.0
RAM 52248 52248 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651178 651178 0 0.0
RAM 60436 60436 0 0.0
thermostat tlsr9518adk80d FLASH 626242 626242 0 0.0
RAM 57132 57132 0 0.0
window-covering tlsr9118bdk40d FLASH 519448 519448 0 0.0
RAM 97848 97848 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1641256 1641256 0 0.0
RAM 48708 48708 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16310718 16310718 0 0.0
RAM 7168520 7168520 0 0.0

@mergify mergify bot merged commit 6768739 into project-chip:master Jul 24, 2024
69 checks passed
@shripad621git shripad621git mentioned this pull request Jul 29, 2024
Closed
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@shripad621git @j-ororke
[ESP32] Changes to support product-appearance attribute in ESP32. (pr…
be453d3 
…oject-chip#34363)

* Changes to support product-appearance attribute on ESP32.

- Added the support for product-appearance attribute of BasicInformationCluster in factory script.
- Added DeviceInstanceInfoProvider implementation for the attribute.

* Addressed review comments

* Changes to support few more missing attributes
@shubhamdp shubhamdp mentioned this pull request Aug 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@shubhamdp shubhamdp shubhamdp approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
esp32 platform review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shripad621git @dhrishi @shubhamdp @bzbarsky-apple