Created automated test TC_ADMIN_1_9: #34342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Follows test steps in test plan PR #CHIP-Specifications/chip-test-plans#4267: -- TH1 able to open commissioning window on DUT -- TH2 Fails to connect to endpoint for 20 iterations with correct payload but incorrect passcode -- TH2 Fails to connect to endpoint due to commissioning window being closed after the 20th failed attempt -- TH1 able to open commissioning window on the endpoint again -- TH1 able to revoke commissioning window on the endpoint
|
PR #34342: Size comparison from 0d740d0 to 44042b4 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Replaced method to get incorrect pincode with using correct pincode in test step 4.
|
PR #34342: Size comparison from 0d740d0 to df56437 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jul 17, 2024
cecille
reviewed
Jul 17, 2024
cecille
reviewed
Jul 17, 2024
Changing test async function to correct name, thank you Cecille! Co-authored-by: C Freeman <[email protected]>
Co-authored-by: C Freeman <[email protected]>
Co-authored-by: C Freeman <[email protected]>
github-actions
bot
added
documentation
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
- Changed factory reset back to true as commissioning failed in CI/CD pipeline without it being set to true
raju-apple
approved these changes
Jul 19, 2024
|
PR #34342: Size comparison from 3418614 to ea60304 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Removed PICS call in CI/CD as not needed - Turned off quiet mode when running test in CI/CD pipeline to help flush out current issue
- Added back removing PICS from script args for running CI/CD pipeline to see if this gets pipeline working again.
|
PR #34342: Size comparison from 9fc8c77 to a19a5a9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Added an additional await to see if we can get test to pass in CI/CD pipeline
|
PR #34342: Size comparison from 9fc8c77 to 444dcae Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Changed method in which CommissionOnNetwork was being established, needed to run through asserts module. - Added await async method for opening commissioning window.
|
PR #34342: Size comparison from 9fc8c77 to b5dfe6c Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
- Turned quiet mode back on for CI/CD pipeline for this test as test is now passing.
|
PR #34342: Size comparison from 9fc8c77 to 63cd22b Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #34342: Size comparison from b426fde to fac0230 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34342: Size comparison from 6da66b7 to 9cc3534 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34342: Size comparison from 7a129d8 to 151de4b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
w8floosh
pushed a commit
to w8floosh/chip-fuzzing
that referenced
this pull request
Aug 4, 2024
* Created automated test TC_ADMIN_1_9: - Follows test steps in test plan PR #CHIP-Specifications/chip-test-plans#4267: -- TH1 able to open commissioning window on DUT -- TH2 Fails to connect to endpoint for 20 iterations with correct payload but incorrect passcode -- TH2 Fails to connect to endpoint due to commissioning window being closed after the 20th failed attempt -- TH1 able to open commissioning window on the endpoint again -- TH1 able to revoke commissioning window on the endpoint * Restyled by autopep8 * Updated TC_CADMIN_1_9 test: - Replaced method to get incorrect pincode with using correct pincode in test step 4. * Update src/python_testing/TC_CADMIN_1_9.py Changing test async function to correct name, thank you Cecille! Co-authored-by: C Freeman <[email protected]> * Update src/python_testing/TC_CADMIN_1_9.py Co-authored-by: C Freeman <[email protected]> * Update src/python_testing/TC_CADMIN_1_9.py Co-authored-by: C Freeman <[email protected]> * Updated tests.yaml and TC_CADMIN_1_9.py: - Added test module TC_CADMIN_1_9 into tests.yaml script - Created new steps method to contain test steps, then call those in variables in main test code area. - Inserted comment for why sleep time duration is needed between test steps 3 and 4, moved sleep time duration into main test code area - Added setting variable for duration of commissioning window using maxCumulativeFailsafeSeconds * Restyled by autopep8 * Updated TC_CADMIN_1_9 test module: - added CI argument blocks to attempt to get test to run in CI * Updated TC_CADMIN_1_9: - Changed method for setting setupPinCode as in CI/CD pipeline it was failing previously. * Restyled by autopep8 * Updated TC_CADMIN_1_9: - Changed factory reset to false to attempt running in CI/CD pipeline * Updated TC_CADMIN_1_9: - Changed factory reset back to true as commissioning failed in CI/CD pipeline without it being set to true * Updated TC_CADMIN_1_9: - Removed PICS call in CI/CD as not needed - Turned off quiet mode when running test in CI/CD pipeline to help flush out current issue * Updated TC_CADMIN_1_9: - Added back removing PICS from script args for running CI/CD pipeline to see if this gets pipeline working again. * Updated TC_CADMIN_1_9: - Added an additional await to see if we can get test to pass in CI/CD pipeline * Updated TC_CADMIN_1_9: - Changed method in which CommissionOnNetwork was being established, needed to run through asserts module. - Added await async method for opening commissioning window. * Updated TC_CADMIN_1_9: - Turned quiet mode back on for CI/CD pipeline for this test as test is now passing. --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: C Freeman <[email protected]>
|
@j-ororke Could you please put the PR to remove TC-CADMIN-1.9 YAML script. Here is the issue for the same: project-chip/matter-test-scripts#363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows test steps in test plan PR #4267: