Launch/Bring to the foreground Content App on Target Navigator and Content Launch Command #34223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Problem] 3P content app does not have permissions to launch itself and put main activity in foreground. This is necessary in response to ContentLauncher and TargetNavigator cluster commands. [Solution] Intercept the LaunchContent and NavigateTarget commands in ContentAppEndpointManagerImpl. Then start content app main/launch activity if it's not already in the foreground before sending command intent. [Testing] WIP
|
PR #34223: Size comparison from 6e31453 to 6edaee2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34223: Size comparison from 8786012 to cde4108 Full report (4 builds for cc32xx, mbed, stm32)
|
lazarkov
changed the title
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34223: Size comparison from 8786012 to 40074d2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lazarkov
force-pushed
the
launch-contentapp-on-command
branch
from
c84abe9 to
96a846b
Compare
|
PR #34223: Size comparison from 90310f2 to 1365db5 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lazarkov
approved these changes
Jul 9, 2024
|
PR #34223: Size comparison from 9306418 to 89f25de Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34223: Size comparison from 8ebe19d to 4d692bb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34223: Size comparison from c6af674 to 14789b1 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 11, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
…ntent Launch Command (project-chip#34223) * Launch content app on command [Problem] 3P content app does not have permissions to launch itself and put main activity in foreground. This is necessary in response to ContentLauncher and TargetNavigator cluster commands. [Solution] Intercept the LaunchContent and NavigateTarget commands in ContentAppEndpointManagerImpl. Then start content app main/launch activity if it's not already in the foreground before sending command intent. [Testing] WIP * Add logic to detect foreground apps * Restyled by whitespace * Restyled by google-java-format * Update code * Restyled by google-java-format --------- Co-authored-by: Lazar Kovacic <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Problem]
3P content app does not have permissions to launch itself and put main activity in foreground. This is necessary in response to ContentLauncher and TargetNavigator cluster commands.
[Solution]
Intercept the LaunchContent and NavigateTarget commands in ContentAppEndpointManagerImpl. Then start content app main/launch activity if it's not already in the foreground before sending command intent.
[Testing]
Tested using TV Android App.
cast cluster targetnavigator navigate-target 1 0 5